Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add $orderby and $order params to filter woocommerce_get_catalog_ordering_args #22257

Merged
merged 1 commit into from Jan 14, 2019

Conversation

Projects
None yet
3 participants
@manchumahara
Copy link
Contributor

commented Dec 18, 2018

Filter woocommerce_get_catalog_ordering_args has only one single argument $args, anyone filter this needs to detect the $orderby and $order value again which is already coded in the method where this filter returns. I hope adding two extra param $orderby and $order will make developer's life easier to hook this filter.

All Submissions:

Changes proposed in this Pull Request:

Method get_catalog_ordering_args in class-wc-query.php , the two variables $orderby and $order already calculated and in the method return filter hook "woocommerce_get_catalog_ordering_args" only have one params $args which I think is not enough or should have more two params $orderby and $order

How to test the changes in this Pull Request:

  1. Nothing specific

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Changelog entry

Add $orderby and $order params to filter woocommerce_get_catalog_ordering_args

Add $orderby and $order params to filter woocommerce_get_catalog_orde…
…ring_args

Filter woocommerce_get_catalog_ordering_args  has only one single argument $args, anyone filter this needs to detect the $orderby and $order value again which is already coded in the method where this filter returns. I hope adding two extra param $orderby and $order will make developer's life easier to hook this filter.

@mikejolley mikejolley added this to the 3.6.0 milestone Jan 14, 2019

@mikejolley mikejolley merged commit 1f63d59 into woocommerce:master Jan 14, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.