Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checkout field locales on first load #22444

Merged
merged 6 commits into from Jan 16, 2019

Conversation

Projects
None yet
3 participants
@mikejolley
Copy link
Member

commented Jan 14, 2019

Updates address-i18n and country-select.js so that on first load, the country boxes trigger a change event. This forces address-i18n to show/hide fields correctly.

To test, make your country on user profile ANGOLA.
Go to checkout.
Confirm postcode field is hidden.

Closes #22119

Also updates priority sorting to cast to integer which fixes #22227.

@mikejolley mikejolley added this to the 3.5.4 milestone Jan 14, 2019

@mikejolley mikejolley changed the title Fix/22119 Fix checkout field locales on first load Jan 14, 2019

@mikejolley

This comment has been minimized.

Copy link
Member Author

commented Jan 15, 2019

Last commit also updates default placeholders to fix #22040

@claudiulodro
Copy link
Contributor

left a comment

I think this looks good. It solves all 3 issues in my testing, and I don't notice any new ones. The code looks good as far as I can tell.

@claudiulodro claudiulodro merged commit c2c7cbe into master Jan 16, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@claudiulodro claudiulodro deleted the fix/22119 branch Jan 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.