Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.6] remove product list suggestions #23211

Merged
merged 3 commits into from
Apr 5, 2019
Merged

[3.6] remove product list suggestions #23211

merged 3 commits into from
Apr 5, 2019

Conversation

haszari
Copy link
Member

@haszari haszari commented Apr 4, 2019

Changes proposed in this Pull Request:

Disable marketplace suggestions in products list.

Closes # .

How to test the changes in this Pull Request:

  1. Checkout this branch and get it set up as the WooCommerce plugin in your development environment.
  2. Log in as a store administrator and view products list – should not see any suggestions.
  3. View products & orders empty state, edit product metabox tab – these suggestions should be unaffected.

@haszari haszari self-assigned this Apr 4, 2019
@haszari haszari added this to the 3.6.0 milestone Apr 4, 2019
@haszari haszari mentioned this pull request Apr 4, 2019
Closed
3 tasks
timmyc
timmyc approved these changes Apr 4, 2019
View reviewed changes
Copy link
Contributor

@timmyc timmyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described on the tin. Thanks Rua 👍

@haszari haszari added the status: in progress This is being worked on. label Apr 5, 2019
@haszari haszari removed the request for review from mikejolley April 5, 2019 06:22
@haszari haszari changed the title remove product list suggestions [experiment] remove product list suggestions Apr 5, 2019
@mattyza mattyza closed this Apr 5, 2019
@timmyc timmyc reopened this Apr 5, 2019
@timmyc timmyc added status: approved and removed status: in progress This is being worked on. labels Apr 5, 2019
@timmyc timmyc changed the title [experiment] remove product list suggestions [3.6] remove product list suggestions Apr 5, 2019
@timmyc timmyc merged commit 835bf3d into master Apr 5, 2019
@timmyc
Copy link
Contributor

timmyc commented Apr 8, 2019

Tagging #23198 as this change is related to the conversation there.

@timmyc timmyc mentioned this pull request Apr 10, 2019
Closed
@kloon kloon deleted the fix/remove-product-list-suggestions branch May 10, 2019 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timmyc timmyc timmyc approved these changes

Assignees

@haszari haszari

Labels
None yet
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@haszari @timmyc @mattyza