Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.6] Update opt-out usage tracking text. #23216

Merged
merged 2 commits into from Apr 8, 2019

Conversation

Projects
None yet
6 participants
@timmyc
Copy link
Contributor

timmyc commented Apr 5, 2019

All Submissions:

Changes proposed in this Pull Request:

This change seeks to make the opt-out explanation more clear. The suggested changes here were given by the Editorial team. /cc @seb86 could you let us know if this reads better to you?

Closes #23208

How to test the changes in this Pull Request:

  1. View the updated text in /wp-admin/admin.php?page=wc-settings&tab=account

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?

Changelog entry

Fix: Make usage tracking opt-out instructions more clear.

@timmyc timmyc added this to the 3.6.0 milestone Apr 5, 2019

@timmyc timmyc requested a review from mikejolley Apr 5, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Apr 5, 2019

Codecov Report

Merging #23216 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted Files Coverage Δ Complexity Δ
...udes/admin/settings/class-wc-settings-accounts.php 94.07% <100%> (ø) 3 <0> (ø) ⬇️
...ncludes/tracks/events/class-wc-orders-tracking.php 0% <0%> (ø) 6% <0%> (+1%) ⬆️
includes/admin/class-wc-admin-setup-wizard.php 18.31% <0%> (+0.06%) 276% <0%> (-1%) ⬇️
includes/wc-template-functions.php 5.48% <0%> (+0.08%) 0% <0%> (ø) ⬇️
includes/class-wc-tax.php 80.94% <0%> (+0.26%) 131% <0%> (ø) ⬇️
includes/wc-core-functions.php 53.57% <0%> (+0.36%) 0% <0%> (ø) ⬇️

@timmyc timmyc changed the title Update opt-out usage tracking text. [3.6] Update opt-out usage tracking text. Apr 5, 2019

@helgatheviking

This comment has been minimized.

Copy link
Contributor

helgatheviking commented Apr 7, 2019

Minor change, but I would propose getting rid of "simply" so that it reads"

"To opt-out, leave this box unchecked. We won’t know this store exists and won’t collect any usage data. %s"

@willgorham

This comment has been minimized.

Copy link
Contributor

willgorham commented Apr 7, 2019

It might be worth clarifying specifically who the 'we' is. e.g. Woocommerce.com? Automattic?

@seb86

This comment has been minimized.

Copy link

seb86 commented Apr 7, 2019

I did mention WooCommerce.com in my rewrite when I posted the issue #23208. Words have power. Use them wisely please. This one mistake could impact WooCommerce. I hate to see that happen.

@@ -244,7 +244,7 @@ public function get_settings() {
'title' => __( 'Enable tracking', 'woocommerce' ),
'desc' => __( 'Allow usage of WooCommerce to be tracked', 'woocommerce' ),
/* Translators: %s URL to tracking info screen. */
'desc_tip' => sprintf( esc_html__( 'If you would rather opt-out, and do not check this box, we will not know this store exists and we will not collect any usage data. %s.', 'woocommerce' ), $tracking_info_text ),
'desc_tip' => sprintf( esc_html__( 'To opt-out, simply leave this box unchecked. We won’t know this store exists and won’t collect any usage data. %s.', 'woocommerce' ), $tracking_info_text ),

This comment has been minimized.

Copy link
@psealock

psealock Apr 8, 2019

Contributor

As suggested in https://wp.me/p2JRYi-402 by @californiakat, this one also alleviates the confusion around who is "we".

Suggested change
'desc_tip' => sprintf( esc_html__( 'To opt-out, simply leave this box unchecked. We won’t know this store exists and won’t collect any usage data. %s.', 'woocommerce' ), $tracking_info_text ),
'desc_tip' => sprintf( esc_html__( 'To opt out, leave this box unticked. Your store remains untracked, and no data will be collected. %s.', 'woocommerce' ), $tracking_info_text ),
@timmyc

This comment has been minimized.

Copy link
Contributor Author

timmyc commented Apr 8, 2019

Thanks everyone for the feedback on this text. Another round of edits based upon feedback from the PR here, and from some internal comments:

image

/cc @seb86 @willgorham @helgatheviking @psealock

@seb86

This comment has been minimized.

Copy link

seb86 commented Apr 8, 2019

@timmyc Much better

@psealock
Copy link
Contributor

psealock left a comment

Thanks everyone, LGTM!

@timmyc timmyc merged commit 616af5c into master Apr 8, 2019

3 checks passed

Scrutinizer No new issues
Details
codecov/project 40.17% (+0.01%) compared to 274a471
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@californiakat

This comment has been minimized.

Copy link

californiakat commented Apr 9, 2019

In my original edit, opt out has no hyphen and that is correct. I didn't commit an error.

opt-out is an adjective or noun, opt out is a verb.

@timmyc timmyc referenced this pull request Apr 9, 2019

Closed

Fix Usage Tracking Description text #23208 #23213

3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.