-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.6] Update opt-out usage tracking text. #23216
Conversation
Codecov Report
|
|
Minor change, but I would propose getting rid of "simply" so that it reads" "To opt-out, leave this box unchecked. We won’t know this store exists and won’t collect any usage data. %s" |
|
It might be worth clarifying specifically who the 'we' is. e.g. Woocommerce.com? Automattic? |
|
I did mention WooCommerce.com in my rewrite when I posted the issue #23208. Words have power. Use them wisely please. This one mistake could impact WooCommerce. I hate to see that happen. |
| @@ -244,7 +244,7 @@ public function get_settings() { | |||
| 'title' => __( 'Enable tracking', 'woocommerce' ), | |||
| 'desc' => __( 'Allow usage of WooCommerce to be tracked', 'woocommerce' ), | |||
| /* Translators: %s URL to tracking info screen. */ | |||
| 'desc_tip' => sprintf( esc_html__( 'If you would rather opt-out, and do not check this box, we will not know this store exists and we will not collect any usage data. %s.', 'woocommerce' ), $tracking_info_text ), | |||
| 'desc_tip' => sprintf( esc_html__( 'To opt-out, simply leave this box unchecked. We won’t know this store exists and won’t collect any usage data. %s.', 'woocommerce' ), $tracking_info_text ), | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As suggested in https://wp.me/p2JRYi-402 by @californiakat, this one also alleviates the confusion around who is "we".
| 'desc_tip' => sprintf( esc_html__( 'To opt-out, simply leave this box unchecked. We won’t know this store exists and won’t collect any usage data. %s.', 'woocommerce' ), $tracking_info_text ), | |
| 'desc_tip' => sprintf( esc_html__( 'To opt out, leave this box unticked. Your store remains untracked, and no data will be collected. %s.', 'woocommerce' ), $tracking_info_text ), |
|
Thanks everyone for the feedback on this text. Another round of edits based upon feedback from the PR here, and from some internal comments: |
|
@timmyc Much better |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks everyone, LGTM!
|
In my original edit, opt out has no hyphen and that is correct. I didn't commit an error. opt-out is an adjective or noun, opt out is a verb. |

All Submissions:
Changes proposed in this Pull Request:
This change seeks to make the opt-out explanation more clear. The suggested changes here were given by the Editorial team. /cc @seb86 could you let us know if this reads better to you?
Closes #23208
How to test the changes in this Pull Request:
/wp-admin/admin.php?page=wc-settings&tab=accountOther information:
Changelog entry