-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.6] Add manage suggestions link into browse-all metabox footer #23229
Conversation
| // Conditionally add in a Manage suggestions link to product edit | ||
| // metabox footer (based on suggestion slug). | ||
| var slugsWithManage = [ | ||
| 'product-edit-empty-footer-browse-all', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that I've added another alias for this suggestion, as the original one was misleading / confusing. I'm renaming it in the json data, but I've got both here. In future we can remove product-edit-empty-footer-browse-all.
Codecov Report
|
@peterfabian the suggestions areas are only shown to users with the capabilities to install plugins, so these links will only be present when the suggestions are visible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Rua, this is testing out well for me. Let's coordinate merges to navigate all the merge conflicts accordingly.
All Submissions:
Changes proposed in this Pull Request:
Adds a "Manage suggestions" link to the product list metabox, linking to settings.
How to test the changes in this Pull Request:
Get more optionstab.Manage suggestionslink at bottom right.Note that the link destination (the new settings section) is implemented in separate PR #23218 .