Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.6] Add manage suggestions link into browse-all metabox footer #23229

Merged
merged 2 commits into from
Apr 8, 2019

Conversation

haszari
Copy link
Member

@haszari haszari commented Apr 7, 2019

All Submissions:

Changes proposed in this Pull Request:

Adds a "Manage suggestions" link to the product list metabox, linking to settings.

How to test the changes in this Pull Request:

  1. Edit a product. Scroll down to metabox, click Get more options tab.
  2. Notice new Manage suggestions link at bottom right.

Note that the link destination (the new settings section) is implemented in separate PR #23218 .

Screen Shot 2019-04-08 at 9 22 37 AM

@haszari haszari self-assigned this Apr 7, 2019
@haszari haszari added this to the 3.6.0 milestone Apr 7, 2019
// Conditionally add in a Manage suggestions link to product edit
// metabox footer (based on suggestion slug).
var slugsWithManage = [
'product-edit-empty-footer-browse-all',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that I've added another alias for this suggestion, as the original one was misleading / confusing. I'm renaming it in the json data, but I've got both here. In future we can remove product-edit-empty-footer-browse-all.

@codecov
Copy link

codecov bot commented Apr 8, 2019

Codecov Report

Merging #23229 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted Files Coverage Δ Complexity Δ
includes/admin/class-wc-admin-assets.php 0% <0%> (ø) 48 <0> (ø) ⬇️

@peterfabian
Copy link
Contributor

peterfabian commented Apr 8, 2019

Similarly to @kloon 's point over at #23218, should this link be shown only to admins/users who actually can change this setting, to prevent confusion?

@peterfabian peterfabian added needs: author feedback The issue/PR needs a response from any of the parties involved in the issue. and removed status: needs review labels Apr 8, 2019
@timmyc
Copy link
Contributor

timmyc commented Apr 8, 2019

Similarly to @kloon 's point over at #23218, should this link be shown only to admins/users who actually can change this setting, to prevent confusion?

@peterfabian the suggestions areas are only shown to users with the capabilities to install plugins, so these links will only be present when the suggestions are visible.

@timmyc timmyc changed the title inject manage link into browse-all metabox footer suggestion [3.6] Add manage suggestions link into browse-all metabox footer Apr 8, 2019
Copy link
Contributor

@timmyc timmyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Rua, this is testing out well for me. Let's coordinate merges to navigate all the merge conflicts accordingly.

@timmyc timmyc removed the needs: author feedback The issue/PR needs a response from any of the parties involved in the issue. label Apr 8, 2019
@timmyc timmyc merged commit 7ac179f into master Apr 8, 2019
@claudiosanches claudiosanches deleted the add/manage-suggestions-metabox-link branch August 2, 2019 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants