Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 'plugin' dashicon to metabox suggestions tab, for consistency #23230

Merged
merged 3 commits into from
Apr 8, 2019

Conversation

haszari
Copy link
Member

@haszari haszari commented Apr 8, 2019

All Submissions:

Changes proposed in this Pull Request:

Adds an icon to the Marketplace Suggestions tab in the product edit metabox. This is more consistent with the other tabs.

Other extensions add tabs to the metabox, using different hooks (which can make it complex to control the order). In some cases the suggestions tab is not displayed last; adding an icon makes the suggestions tab consistent with those above and below.

How to test the changes in this Pull Request:

  1. Edit a product, scroll down to metabox.
  2. View Get more options tab – now has an icon.

Screen Shot 2019-04-08 at 1 00 15 PM

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?

@haszari haszari self-assigned this Apr 8, 2019
@haszari haszari added this to the 3.6.0 milestone Apr 8, 2019
@haszari haszari added status: needs review status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. and removed status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. labels Apr 8, 2019
@haszari haszari requested a review from kloon April 8, 2019 01:19
Copy link
Contributor

@timmyc timmyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haszari looking good, but I am seeing what looks like some missing padding when viewed in a narrow viewport:

icon-narrow-viewport

@timmyc timmyc added needs: author feedback The issue/PR needs a response from any of the parties involved in the issue. and removed status: needs review labels Apr 8, 2019
@haszari
Copy link
Member Author

haszari commented Apr 8, 2019

@timmyc good spotting, now has the same responsive rule to set line height:

Screen Shot 2019-04-09 at 8 53 35 AM

@haszari haszari force-pushed the add/product-metabox-suggestions-tab-icon branch from cef51f0 to 0ad914f Compare April 8, 2019 22:00
Copy link
Contributor

@timmyc timmyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little icon is looking quite happy in narrow viewports now. LGTM.

@timmyc timmyc removed the needs: author feedback The issue/PR needs a response from any of the parties involved in the issue. label Apr 8, 2019
@timmyc timmyc merged commit 14d86a4 into master Apr 8, 2019
@claudiosanches claudiosanches deleted the add/product-metabox-suggestions-tab-icon branch August 2, 2019 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants