Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Emoji from default additional email content #24450

Merged
merged 1 commit into from Aug 22, 2019

Conversation

@claudiosanches
Copy link
Member

commented Aug 20, 2019

All Submissions:

Changes proposed in this Pull Request:

This doesn't affect all installations, since this issue depends on the database structure, not all WordPress installations properly support emojis, this will stop email settings to get saved, so it's easy to just remove this emoji for now.

Closes #24405.

How to test the changes in this Pull Request:

  1. Since this not affect all installations may become hard to test, but you can try change the database to something else that is not utf8mb4.
  2. Try save the settings with an emoji like 馃檶, this may stop the page get saved, you can try reload or access the URL again: wp-admin/admin.php?page=wc-settings&tab=email&section=wc_email_new_order
  3. And now the only way to save is to remove all emojis from the content.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?

Changelog entry

Fix - Removed Emoji from default additional email content due problem on some database that doesn't allow Emojis.

@codecov

This comment has been minimized.

Copy link

commented Aug 20, 2019

Codecov Report

Merging #24450 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted Files Coverage 螖 Complexity 螖
includes/emails/class-wc-email-new-order.php 70.11% <100%> (酶) 13 <0> (酶) 猬囷笍
...shipping/flat-rate/includes/settings-flat-rate.php 91.84% <0%> (-4.08%) 0% <0%> (酶)

@vedanshujain vedanshujain added this to the 3.7.1 milestone Aug 22, 2019

@vedanshujain
Copy link
Contributor

left a comment

LGTM!

@vedanshujain vedanshujain merged commit 5d1a70b into master Aug 22, 2019

3 checks passed

Scrutinizer 8 new issues
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +66.9% compared to 500373f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@vedanshujain vedanshujain deleted the fix/24405 branch Aug 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.