Update count param consistently. #31227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barryhughes
previously approved these changes
Nov 17, 2021
As far as I can see, this count param is not really needed, but it will still be good to keep it updated in case its getting used in an edge case that I have not considered.
vedanshujain
force-pushed
the
fix/count_param
branch
from
2fa8e96
to
2013a66
Compare
|
✍🏽 Looks like the failing check is unrelated and also is solved by this PR. |
barryhughes
reviewed
Nov 22, 2021
| @@ -270,7 +270,7 @@ public static function parse_file_path( $file_path ) { | |||
| ); | |||
|
|
|||
| $count = 0; | |||
| $file_path = str_replace( array_keys( $replacements ), array_values( $replacements ), $file_path ); | |||
| $file_path = str_replace( array_keys( $replacements ), array_values( $replacements ), $file_path, $count ); | |||
There was a problem hiding this comment.
With this, we no longer need to explicitly initialize $count to zero (line 272) but I think it's fine/actually makes things a little clearer.
|
Hi @barryhughes, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:
|
barryhughes
added
the
release: add changelog
jonathansadowski
added
changelog added
and removed
release: add changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
As far as I can see, this count param is not really needed, but it will still be good to keep it updated in case its getting used in an edge case that I have not considered.
How to test the changes in this Pull Request:
This is more of a consistency fix. Make sure all test case pass.
Other information:
Changelog entry
FOR PR REVIEWER ONLY: