Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basis of overlay used when processing Twenty Twenty-Two checkout. #31633

Merged
merged 3 commits into from Jan 13, 2022

Conversation

barryhughes
Copy link
Member

@barryhughes barryhughes commented Jan 13, 2022

Aims to address a problem when running alongside Twenty Twenty-Two whereby the blocked UI overlay (that 'greys out' the checkout form and displays a spinner after submitting the form) was not visible.

checkout-overlay-spinner.mov

Updates #31324.

@@ -26,6 +26,7 @@
}

@import "mixins";
@import "animation";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Point of interest: this isn't used in the Twenty Twenty One stylesheet, as it is hinging on a similar keyframe definition that is supplied by Blocks.

@barryhughes barryhughes marked this pull request as ready for review January 13, 2022 01:13
Copy link
Contributor

@jeffstieler jeffstieler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - merge when CI passes. 🚀

@vedanshujain vedanshujain merged commit 2a3360f into trunk Jan 13, 2022
@vedanshujain vedanshujain deleted the fix/31324-checkout-block-overlay branch January 13, 2022 03:51
@github-actions github-actions bot added this to the 6.2.0 milestone Jan 13, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 13, 2022

Hi @vedanshujain, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the status: needs changelog label
  • Add the status: needs testing instructions label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants