Fix WCA fatal with bail conditions for WCA execution paths #32814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
plugin: woocommerce
ilyasfoo
force-pushed
the
fix/32797-wca-fatal
branch
from
8c905cb
to
4dec248
Compare
ilyasfoo
commented
Apr 28, 2022
ilyasfoo
commented
Apr 28, 2022
| if ( ! defined( 'WC_ABSPATH' ) ) { | ||
| return; | ||
| } | ||
| return WCAdminAssets::should_use_minified_js_file( $script_debug ); |
There was a problem hiding this comment.
No deprecation notice via wc_deprecated_function since it also causes output during activation, which would break plugin activation.
ilyasfoo
commented
Apr 28, 2022
| @@ -84,30 +84,29 @@ public function __construct() { | |||
| */ | |||
| remove_action( 'admin_print_scripts', 'print_emoji_detection_script' ); | |||
|
|
|||
| add_action( 'admin_init', array( __CLASS__, 'is_using_installed_wc_admin_plugin' ) ); | |||
| add_action( 'admin_init', array( __CLASS__, 'deactivate_wc_admin_plugin' ) ); | |||
There was a problem hiding this comment.
Replacing the now obsolete version check with deactivation check
ilyasfoo
added
the
release: cherry-pick
adrianduffell
approved these changes
Apr 29, 2022
There was a problem hiding this comment.
This tested well and LGTM! Thanks for wrangling this @ilyasfoo 👍 🚀
|
Hi @ilyasfoo, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:
|
claudiosanches
removed
the
release: cherry-pick
adrianduffell
added
release: cherry-pick
This was referenced Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Closes #32797. This PR:
How to test the changes in this Pull Request:
Build WooCommerce zip
git cherry-pick 1bbf2f50d390acad83b023d1ebe61224944fd102to get proper WC version in autoloader (Original PR). Otherwise WCAdmin plugin may take precedencepnpm nx build:zip woocommerceto build the zipTesting on existing activated plugin
Testing new activation
FOR PR REVIEWER ONLY: