Schema Filter for downloadable products. #3297

Closed
wants to merge 7 commits into
from

Conversation

Projects
None yet
4 participants
@seb86

seb86 commented Jun 7, 2013

This is for filtering the schema data for downloadable products. This will allow developers to further expand extension ideas.

@coenjacobs

This comment has been minimized.

Show comment
Hide comment
@coenjacobs

coenjacobs Jun 10, 2013

Contributor

See #3295 for a detailed description.

Contributor

coenjacobs commented Jun 10, 2013

See #3295 for a detailed description.

@mikejolley

This comment has been minimized.

Show comment
Hide comment
@mikejolley

mikejolley Jun 10, 2013

Member

Interesting. Ill need to look at this one in more depth. Might be better to have a get_schema method rather than a hooked in template?

Member

mikejolley commented Jun 10, 2013

Interesting. Ill need to look at this one in more depth. Might be better to have a get_schema method rather than a hooked in template?

@seb86

This comment has been minimized.

Show comment
Hide comment
@seb86

seb86 Jun 10, 2013

Ok great. The code I submitted was written quickly to show an example of the possibilities. If there is a better way to put this in place, i'm all ears.

seb86 commented Jun 10, 2013

Ok great. The code I submitted was written quickly to show an example of the possibilities. If there is a better way to put this in place, i'm all ears.

@coenjacobs

This comment has been minimized.

Show comment
Hide comment
@coenjacobs

coenjacobs Jun 11, 2013

Contributor

Just a quick note: This needs a default value (even for downloadable products) that will use the default schema output. This will be used for downloads that don't fit in a specific download type (or when not set).

Contributor

coenjacobs commented Jun 11, 2013

Just a quick note: This needs a default value (even for downloadable products) that will use the default schema output. This will be used for downloads that don't fit in a specific download type (or when not set).

@seb86

This comment has been minimized.

Show comment
Hide comment
@seb86

seb86 Jun 11, 2013

I have tested the code and it works on my end. Please verify. This would be great if it was added for the next release. Thanks.

seb86 commented Jun 11, 2013

I have tested the code and it works on my end. Please verify. This would be great if it was added for the next release. Thanks.

@douglance

This comment has been minimized.

Show comment
Hide comment
@douglance

douglance Jun 19, 2013

It'd be great to be able to filter available downloads for people based on date of their sign-up, i.e. digital magazine subscriptions.

It'd be great to be able to filter available downloads for people based on date of their sign-up, i.e. digital magazine subscriptions.

@seb86

This comment has been minimized.

Show comment
Hide comment
@seb86

seb86 Jun 19, 2013

Can you explain a little more about how that would be part of the schema @douglance Thanks.

seb86 commented Jun 19, 2013

Can you explain a little more about how that would be part of the schema @douglance Thanks.

@seb86

This comment has been minimized.

Show comment
Hide comment
@seb86

seb86 Aug 20, 2013

So is this now merged @mikejolley ?

seb86 commented Aug 20, 2013

So is this now merged @mikejolley ?

@mikejolley

This comment has been minimized.

Show comment
Hide comment
@mikejolley

mikejolley Aug 20, 2013

Member

Sort of, it wouldn't mege automatically due to recent changes so I put my take on it. Rather than having a template file, I've just added a function to the actual itemscope param

Member

mikejolley commented Aug 20, 2013

Sort of, it wouldn't mege automatically due to recent changes so I put my take on it. Rather than having a template file, I've just added a function to the actual itemscope param

@seb86

This comment has been minimized.

Show comment
Hide comment
@seb86

seb86 Aug 20, 2013

@mikejolley It looks good. Will I still be credited for this feature ?

seb86 commented Aug 20, 2013

@mikejolley It looks good. Will I still be credited for this feature ?

@mikejolley

This comment has been minimized.

Show comment
Hide comment
@mikejolley

mikejolley Aug 20, 2013

Member

@seb86 I didn't merge it, so it won't show you on github.

Member

mikejolley commented Aug 20, 2013

@seb86 I didn't merge it, so it won't show you on github.

@seb86

This comment has been minimized.

Show comment
Hide comment
@seb86

seb86 Aug 20, 2013

@mikejolley oh :( Will I still be named in the readme.txt file then ?

seb86 commented Aug 20, 2013

@mikejolley oh :( Will I still be named in the readme.txt file then ?

@coenjacobs

This comment has been minimized.

Show comment
Hide comment
@coenjacobs

coenjacobs Aug 21, 2013

Contributor

@seb86 Nobody is mentioned in the readme.txt file, you can just have your name in the contributors list (also shown in welcome screen of the plugin) if your patch is merged in.

Contributor

coenjacobs commented Aug 21, 2013

@seb86 Nobody is mentioned in the readme.txt file, you can just have your name in the contributors list (also shown in welcome screen of the plugin) if your patch is merged in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment