Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes a WP nightly unity test #34190

Merged
merged 2 commits into from Aug 4, 2022
Merged

Fixes a WP nightly unity test #34190

merged 2 commits into from Aug 4, 2022

Conversation

vedanshujain
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

In WP 6.1, a new doing_it_wrong message is being added to prevent checking for cache with boolean key. Seems like we were accidentally using a boolean key in one of the test.

How to test the changes in this Pull Request:

Make sure that tests pass.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file for each project being changed, ie pnpm changelog add --filter=<project>?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Aug 4, 2022
@jorgeatorres jorgeatorres self-requested a review August 4, 2022 12:43
Copy link
Member

@jorgeatorres jorgeatorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks V!
(Waiting for CI to complete before merging)

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2022

Test Results Summary

Commit SHA: 3110555

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests11500201170m 40s
E2E Tests185001018611m 20s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@jorgeatorres jorgeatorres merged commit 5f0efcf into trunk Aug 4, 2022
@jorgeatorres jorgeatorres deleted the fix/unit-nightly branch August 4, 2022 13:00
@github-actions github-actions bot added this to the 6.9.0 milestone Aug 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2022

Hi @jorgeatorres, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants