Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix onboarding wizard popover padding #34896

Merged
merged 2 commits into from Oct 3, 2022

Conversation

chihsuan
Copy link
Member

@chihsuan chihsuan commented Sep 30, 2022

All Submissions:

Changes proposed in this Pull Request:

Closes #34884

The info icon (i) text fails to show padding after clicking on Product types step of OBW in WP 6.1 because we added padding to an inner div but it has been removed.

WP6.0:

Screen Shot 2022-09-30 at 14 44 11

WP6.1:

Screen Shot 2022-09-30 at 14 43 52

This PR adds the padding to the popover content div directly.

How to test the changes in this Pull Request:

  1. Use a site with WP 6.1
  2. Go to OBW.
  3. Go to Product types step.
  4. Click on an info icon (i).
  5. Observe that, Info icon (i) popover content show with padding.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> run changelog add?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Sep 30, 2022
@chihsuan chihsuan marked this pull request as ready for review September 30, 2022 06:52
@chihsuan chihsuan self-assigned this Sep 30, 2022
@chihsuan chihsuan requested a review from a team September 30, 2022 06:52
@github-actions
Copy link
Contributor

github-actions bot commented Sep 30, 2022

Test Results Summary

Commit SHA: a24764f

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests11800201200m 46s
E2E Tests187002018914m 11s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@chihsuan chihsuan force-pushed the fix/34884-info-icon-fails-to-show-padding branch from 5e8ad52 to a24764f Compare October 3, 2022 05:14
Copy link
Contributor

@rjchow rjchow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, fixes the issue! Thanks!

@chihsuan chihsuan merged commit 08848d4 into trunk Oct 3, 2022
@chihsuan chihsuan deleted the fix/34884-info-icon-fails-to-show-padding branch October 3, 2022 08:34
@github-actions github-actions bot added this to the 7.1.0 milestone Oct 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2022

Hi @chihsuan, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GlobalStep] [WP6.1] Info icon (i) text fails to show padding after clicking on Product types step of OBW.
2 participants