Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update product mvp feature flag #36552

Merged
merged 4 commits into from Jan 23, 2023
Merged

Update product mvp feature flag #36552

merged 4 commits into from Jan 23, 2023

Conversation

louwie17
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Move feature flag of product MVP down to experimental and add additional note that this is in development.

  • This PR is a very minor change/addition and does not require testing instructions (if checked you can ignore/remove the next section).

How to test the changes in this Pull Request:

  1. Go to WooCommerce > Settings > Advanced > Features
  2. Make sure the New product editor is under experimental features and an additional note is displayed underneath.
  3. You should still be able to enable/disable this feature flag.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> changelog add?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Jan 23, 2023
AnnaMag
AnnaMag reviewed Jan 23, 2023
View reviewed changes
plugins/woocommerce/src/Internal/Features/FeaturesController.php Outdated
@@ -621,6 +621,10 @@ private function get_setting_for_feature( string $feature_id, array $feature, bo
}
}

if ( 'new_product_management' === $feature_id ) {
$desc_tip = __( "⚠ This feature is currently in development and only available for simple products. No extension support yet.", 'woocommerce' );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@louwie17 I believe we should make it disabled as the HPOS and remove the tooltip for the time being. What do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-01-23 at 11 49 47

@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2023 •
edited

Test Results Summary

Commit SHA: 4e92706

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 59s
E2E Tests189006019515m 18s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@AnnaMag AnnaMag self-requested a review January 23, 2023 11:08
AnnaMag
AnnaMag previously approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@AnnaMag AnnaMag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@AnnaMag AnnaMag self-requested a review January 23, 2023 11:11
@louwie17 louwie17 merged commit 4ff0aeb into trunk Jan 23, 2023
@louwie17 louwie17 deleted the update/product_mvp_feature_flag branch January 23, 2023 11:43
@github-actions github-actions bot added this to the 7.4.0 milestone Jan 23, 2023
vedanshujain pushed a commit that referenced this pull request Jan 25, 2023
@louwie17 @vedanshujain
Update product mvp feature flag (#36552)
278c154 
* Move product management feature to experimental and add additional note.

* Add changelog

* Remove tooltip

* Fix lint error
@github-actions github-actions bot mentioned this pull request Feb 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnnaMag AnnaMag AnnaMag approved these changes

Assignees
No one assigned
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Milestone
7.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@louwie17 @AnnaMag