Add date index to order tables for speeding up order list query.

[vedanshujain]

Submission Review Guidelines:

• I have followed the WooCommerce Contributing Guidelines and the WordPress Coding Standards.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have reviewed my code for security best practices.
• Following the above guidelines will result in quick merges and clear and detailed feedback when appropriate.

Changes proposed in this Pull Request:

This adds the equivalent index of wp_posts' type_status_date, the main impact of this index would be on the order list page for large sites. Additionally, it also connects WC_Install's create table method to HPOS when it is enabled.

Closes #35465

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

1. Set HPOS to authoritative, or data sync to enabled, or both. (So that HPOS tables are registered and created).
2. Testing this needs to trigger the update flow, the easiest option is to update the WooCommerce version to a lower one, like so:
   wp option update woocommerce_version 7.9.0
3. Refresh any WooCommerce admin page, so that update is triggered.
4. Verify that woocommerce version was updated, by running wp option get woocommerce_version, it should be greater than 7.9.0.
5. Check that the index was created as expected, by running wp db query "show index from wp_wc_orders where Key_name like 'type_status_date'", it should show 3 rows for each index in query like this:

+--------------+------------+------------------+--------------+------------------+-----------+-------------+----------+--------+------+------------+---------+---------------+
| Table        | Non_unique | Key_name         | Seq_in_index | Column_name      | Collation | Cardinality | Sub_part | Packed | Null | Index_type | Comment | Index_comment |
+--------------+------------+------------------+--------------+------------------+-----------+-------------+----------+--------+------+------------+---------+---------------+
| wp_wc_orders |          1 | type_status_date |            1 | type             | A         |           3 |     NULL | NULL   | YES  | BTREE      |         |               |
| wp_wc_orders |          1 | type_status_date |            2 | status           | A         |          10 |     NULL | NULL   | YES  | BTREE      |         |               |
| wp_wc_orders |          1 | type_status_date |            3 | date_created_gmt | A         |         309 |     NULL | NULL   | YES  | BTREE      |         |               |
+--------------+------------+------------------+--------------+------------------+-----------+-------------+----------+--------+------+------------+---------+---------------+

Changelog entry

• Automatically create a changelog entry from the details below.

Significance

• Patch
• Minor
• Major

Type

• Fix - Fixes an existing bug
• Add - Adds functionality
• Update - Update existing functionality
• Dev - Development related task
• Tweak - A minor adjustment to the codebase
• Performance - Address performance issues
• Enhancement - Improvement to existing functionality

Message

Comment

[github-actions]

Test Results Summary

Commit SHA: 9b6c7ba

Test 🧪	Passed ✅	Failed 🚨	Broken 🚧	Skipped ⏭️	Unknown ❔	Total 📊	Duration ⏱️
API Tests	259	0	0	2	0	261	0m 54s
E2E Tests	195	0	0	15	0	210	16m 40s

---

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

[github-actions]

Hi @barryhughes,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

[barryhughes]

Left a non-blocking question (it's not a request for changes, though). Looks good and tests well (key was established, order list table functions as before). Thanks!

[barryhughes]

Not a request to change anything, more asking out of curiosity. At this stage, with HPOS on the verge of being marked stable, might we not simply create the HPOS tables as standard?

[vedanshujain]

Actually, that's not a bad idea. I think we can do in preparation for a larger move. Would you like to create an issue for this?

[barryhughes]

Created (and added to the project board) ✅