New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache Marketplace search results #40492
Conversation
Test Results SummaryCommit SHA: 952e4bd
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
|
Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
…ithub.com/woocommerce/woocommerce into add/wccom-18292-cache-marketplace-results
plugins/woocommerce-admin/client/marketplace/components/extensions/extensions.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks clean and works great on my end. Love it. Thank you @Dan-Q!
Changes proposed in this Pull Request:
Closes WCCOM#18292. The 100 most-recent search/browse/features/category-list results in the Marketplace are cached into a
Mapso that if you do the same browse/search again you get instant results (and don't hit our API) until you navigate away or actually refresh.How to test the changes in this Pull Request:
cd plugins/woocommerce-admin && pnpm startChangelog entry
Significance
Type
Message
Comment
Memory-cache In-App Marketplace search, browse, and category API hits, for performance.