Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache Marketplace search results #40492

Merged
merged 21 commits into from Oct 12, 2023
Merged

Conversation

Dan-Q
Copy link
Contributor

@Dan-Q Dan-Q commented Sep 28, 2023

Changes proposed in this Pull Request:

Closes WCCOM#18292. The 100 most-recent search/browse/features/category-list results in the Marketplace are cached into a Map so that if you do the same browse/search again you get instant results (and don't hit our API) until you navigate away or actually refresh.

How to test the changes in this Pull Request:

  1. Check out this branch.
  2. Recompile assets e.g. cd plugins/woocommerce-admin && pnpm start
  3. In your test environment, visit WooCommerce > Extensions
  4. Browse and search. Notice (e.g. using your browser's debug > network panel) that repeat searches/browses don't result in repeat API hits.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

Memory-cache In-App Marketplace search, browse, and category API hits, for performance.

@Dan-Q Dan-Q self-assigned this Sep 28, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 28, 2023

Test Results Summary

Commit SHA: 952e4bd

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 55s
E2E Tests212004021616m 56s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@Dan-Q Dan-Q requested review from a team, bgrgicak and raicem and removed request for a team September 29, 2023 09:58
@github-actions
Copy link
Contributor

Hi @bgrgicak, @raicem,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@Dan-Q Dan-Q marked this pull request as ready for review September 29, 2023 10:00
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Sep 29, 2023
Copy link
Contributor

@raicem raicem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean and works great on my end. Love it. Thank you @Dan-Q!

@Dan-Q Dan-Q merged commit 874a3b5 into trunk Oct 12, 2023
26 checks passed
@Dan-Q Dan-Q deleted the add/wccom-18292-cache-marketplace-results branch October 12, 2023 10:44
@github-actions github-actions bot added this to the 8.3.0 milestone Oct 12, 2023
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Oct 12, 2023
@nigeljamesstevenson nigeljamesstevenson added needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants