Marketplace: Fix the Marketplace header being invisible after viewing other WC Admin pages. #40562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raicem
requested review from
bgrgicak and
andfinally
and removed request for
a team
|
Hi @Dan-Q, @bgrgicak, @andfinally, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Test Results SummaryCommit SHA: 44f76f6
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
kdevnel
approved these changes
Oct 3, 2023
| @@ -20,7 +20,7 @@ | |||
| } | |||
|
|
|||
| @media (width <= $breakpoint-medium) { | |||
| margin: $content-spacing-small; | |||
| margin: $grid-unit-20 $grid-unit-20 $grid-unit-10 $grid-unit-20; | |||
There was a problem hiding this comment.
Appreciate that you're switching over to the standard variables instead of our custom ones. That was my hope over time!
andfinally
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
Everything looks great – tested old and new marketplaces, and other admin pages in WordPress and WooCommerce. Big thanks to you and @kdevnel for addressing this! 💯
Previous method caused issues when you go from WooCommerce > Home to WooCommerce > Marketplace. The header was going missing on the Marketplace page.
andfinally
force-pushed
the
fix/wccom-18329-unvisible-header
branch
from
227e45c
to
44f76f6
Compare
github-actions
bot
added
the
plugin: woocommerce
github-actions
bot
added
the
needs: analysis
alopezari
added
needs: external testing
github-actions bot
pushed a commit
that referenced
this pull request
Oct 3, 2023
… other WC Admin pages. (#40562)
lanej0
pushed a commit
that referenced
this pull request
Oct 3, 2023
* Marketplace: Fix the Marketplace header being invisible after viewing other WC Admin pages. (#40562) * Prep for cherry pick 40562 --------- Co-authored-by: And Finally <andfinally@users.noreply.github.com> Co-authored-by: WooCommerce Bot <no-reply@woocommerce.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Review Guidelines:
Changes proposed in this Pull Request:
Change the way we space out the heading and the content area. The previous method caused issues when you go from WooCommerce > Home to WooCommerce > Marketplace. The header was going missing on the Marketplace page.
How to test the changes in this Pull Request:
Changelog entry
Significance
Type
Message
Comment Fix the Marketplace header being invisible after viewing other WC Admin pages.