Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marketplace search improvements #40667

Merged
merged 8 commits into from Oct 17, 2023
Merged

Conversation

bgrgicak
Copy link
Contributor

@bgrgicak bgrgicak commented Oct 10, 2023

Changes proposed in this Pull Request:

This PR improves the search experience in the new Marketplace by showing themes first if there are no extensions, empty search will open the discovery page, and large screens will show 8 results if available.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Search for a theme that doesn't have extensions as results
  2. Confirm that themes are show first and the no-results for extensions components is shown bellow
  3. Press enter while focused on the empty search box
  4. Confirm that it loads the discovery page
  5. Search for a product
  6. Expand your window above 1920px
  7. Confirm that 8 search results are show if available
  8. Reduce your window width bellow 1920px
  9. Confirm that 6 items are shown
  10. Click on View all
  11. Confirm that all results are loaded

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

In the marketplace show themes first if there are no extensions, empty search will open the discovery page, and large screens will show 8 results if available.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2023

Test Results Summary

Commit SHA: b27bacf

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202611m 8s
E2E Tests212004021620m 13s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@bgrgicak bgrgicak self-assigned this Oct 10, 2023
@bgrgicak bgrgicak marked this pull request as ready for review October 10, 2023 11:53
@bgrgicak bgrgicak requested review from a team, Dan-Q, raicem and andfinally and removed request for a team and raicem October 10, 2023 11:53
@bgrgicak bgrgicak added focus: react marketplace Issues relating to the React Marketplace team: Fire labels Oct 10, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2023

Hi @Dan-Q, @andfinally,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

@andfinally andfinally left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such a pleasure to see these changes, thank you! 💯 Makes the UI neater and more useful.

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Oct 12, 2023
@andfinally
Copy link
Contributor

As we're under-strength at the moment, I would be OK with merging this with one review.

@bgrgicak bgrgicak merged commit 7cd33b5 into trunk Oct 17, 2023
26 checks passed
@bgrgicak bgrgicak deleted the fix/marketplace-search-feedback branch October 17, 2023 16:32
@github-actions github-actions bot added this to the 8.3.0 milestone Oct 17, 2023
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Oct 17, 2023
@rodelgc rodelgc added status: analysis complete Indicates if a PR has been analysed by Solaris needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Oct 18, 2023
@nigeljamesstevenson nigeljamesstevenson added the release: highlight Issues that have a high user impact and need to be discussed/paid attention to. label Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: react marketplace Issues relating to the React Marketplace needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. plugin: woocommerce Issues related to the WooCommerce Core plugin. release: highlight Issues that have a high user impact and need to be discussed/paid attention to. status: analysis complete Indicates if a PR has been analysed by Solaris team: Fire
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants