New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Marketplace search improvements #40667
Conversation
Test Results SummaryCommit SHA: b27bacf
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
|
Hi @Dan-Q, @andfinally, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Such a pleasure to see these changes, thank you! 💯 Makes the UI neater and more useful.
...oocommerce-admin/client/marketplace/components/product-list-content/product-list-content.tsx
Show resolved
Hide resolved
plugins/woocommerce-admin/client/marketplace/components/tabs/tabs.tsx
Outdated
Show resolved
Hide resolved
|
As we're under-strength at the moment, I would be OK with merging this with one review. |
Changes proposed in this Pull Request:
This PR improves the search experience in the new Marketplace by showing themes first if there are no extensions, empty search will open the discovery page, and large screens will show 8 results if available.
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
Changelog entry
Significance
Type
Message
Comment
In the marketplace show themes first if there are no extensions, empty search will open the discovery page, and large screens will show 8 results if available.