Fix fatal strpos in ComparisonOperation 8.5 branch

[ilyasfoo]

Submission Review Guidelines:

Related to fix in #44007

Changes proposed in this Pull Request:

• Adds defensive checks

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

1. Set up a fresh site
2. Go to WooCommerce Setup Wizard
3. In country step, select Australia (to trigger the RIN rule)
4. Skip plugins step
5. Observe no fatal

Changelog entry

• Automatically create a changelog entry from the details below.

Significance

• Patch
• Minor
• Major

Type

• Fix - Fixes an existing bug
• Add - Adds functionality
• Update - Update existing functionality
• Dev - Development related task
• Tweak - A minor adjustment to the codebase
• Performance - Address performance issues
• Enhancement - Improvement to existing functionality

Message

Comment

[github-actions]

Test Results Summary

Commit SHA: dae3464

Test 🧪	Passed ✅	Failed 🚨	Broken 🚧	Skipped ⏭️	Unknown ❔	Total 📊	Duration ⏱️
API Tests	259	0	0	2	0	261	0m 37s
E2E Tests	258	0	0	3	0	261	14m 23s

---

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

[github-actions]

Hi @psealock, @chihsuan, @woocommerce/ghidorah

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

[psealock]

This tests well and changes are consistent with https://github.com/woocommerce/woocommerce/pull/44007/files.

Do we need to consider the change that caused this in the first place? I'm not fully understanding what changed in order to make this fail.

[chihsuan]

Looks good and tested well! 🚢

[ilyasfoo]

Do we need to consider the change that caused this in the first place? I'm not fully understanding what changed in order to make this fail.

Thanks, @psealock! Yes, this will be address in follow-up PRs. Some of the details are recorded in this post (pf59Ax-D1-p2#comment-415):

It seems the way that dot_notation transformer works is when a value obtained is null, the transformer returns the previous value. This resulted in the evaluator unexpectedly returning an array instead of a string, causing the error in strpos.