Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MOAR unit tests #6176

Merged
merged 15 commits into from Sep 7, 2014

Conversation

Projects
None yet
5 participants
@maxrice
Copy link
Contributor

commented Sep 5, 2014

  • Mock session handler
  • 100% coverage for wc-coupon-functions.php
  • 100% coverage for wc-notice-functions.php
  • 100% coverage for wc-formatting-functions.php
  • Webhook factory as a reference implementation for other classes that use a custom post type (coupons, orders, products)
@claudiosanches

This comment has been minimized.

Copy link
Member

commented Sep 5, 2014

❤️

@seanreloaded

This comment has been minimized.

Copy link
Contributor

commented Sep 5, 2014

Wow.. Nice!

@maxrice

This comment has been minimized.

Copy link
Contributor Author

commented Sep 7, 2014

@mikejolley the latest set of commits add code coverage reports via Coveralls -- you'll need to sign into their website and turn on coverage for the repo and then add the little coverage badge 😸

@claudiosanches

This comment has been minimized.

Copy link
Member

commented Sep 7, 2014

I'll try improve this ~> Scrutinizer Code Quality

@maxrice

This comment has been minimized.

Copy link
Contributor Author

commented Sep 7, 2014

@claudiosmweb yeah it had a big list of recommendations along with a patch file that should make it easy to bring in the changes. Mostly just phpdoc stuff IIRC.

@claudiosanches

This comment has been minimized.

Copy link
Member

commented Sep 7, 2014

@maxrice yes, it's very simple and I think we deserve at least a score of 9.0 :P

@mikejolley

This comment has been minimized.

Copy link
Member

commented Sep 7, 2014

@maxrice @claudiosmweb some of the suggested changes (docblock) I'm not 100% happy with which is why I have not done that yet. e.g. it doesn't recognise values in apply_filters

@maxrice

This comment has been minimized.

Copy link
Contributor Author

commented Sep 7, 2014

@mikejolley yeah I figured the generated path would require some manual changes before it was suitable for merging. In 90ebdc2 I added a scrutinizer config file so it's easier to control the analysis.

mikejolley added a commit that referenced this pull request Sep 7, 2014

@mikejolley mikejolley merged commit 801dddf into woocommerce:master Sep 7, 2014

2 checks passed

ci/scrutinizer Scrutinizer: 30 new issues, 45 updated code elements — Tests: passed
Details
continuous-integration/travis-ci The Travis CI build passed
Details

@maxrice maxrice deleted the maxrice:moar-unit-tests branch Sep 8, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.