New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter the array which determines what classes are applied to an order note #9088

Merged
merged 3 commits into from Sep 15, 2015

Conversation

Projects
None yet
3 participants
@khag7
Contributor

khag7 commented Sep 9, 2015

Allows plugins to hook into the order notes meta box

Useful to highlight notes with different colors based on the comment meta

Example: I have a plugin which allows custom meta to be added to comments (a drop down box below the order note entry box allows a note to be assigned as a task to another user) and with this hook I will be able to add classes to the order note for better CSS styling

khag7 added some commits Sep 7, 2015

Merge pull request #2 from khag7/khag7-patch-1
fix HTML for the order total column
add a filter to the array of the html classes for an order note
allow plugins to hook into the display of order notes to add classes.
@mikejolley

This comment has been minimized.

Show comment
Hide comment
@mikejolley

mikejolley Sep 9, 2015

Member

Does this follow the naming of other 'class' filters? Take care of spacing too please. https://make.wordpress.org/core/handbook/best-practices/coding-standards/php/

Member

mikejolley commented Sep 9, 2015

Does this follow the naming of other 'class' filters? Take care of spacing too please. https://make.wordpress.org/core/handbook/best-practices/coding-standards/php/

@mikejolley mikejolley added this to the 2.5 (name undecided) milestone Sep 9, 2015

@khag7

This comment has been minimized.

Show comment
Hide comment
@khag7

khag7 Sep 9, 2015

Contributor

Thanks for criticizing my work. I'm new at this. Maybe that's obvious.

Contributor

khag7 commented Sep 9, 2015

Thanks for criticizing my work. I'm new at this. Maybe that's obvious.

claudiosanches added a commit that referenced this pull request Sep 15, 2015

Merge pull request #9088 from khag7/khag7-patch-1
Filter the array which determines what classes are applied to an order note

@claudiosanches claudiosanches merged commit ab921ea into woocommerce:master Sep 15, 2015

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
Scrutinizer No new issues
Details

@khag7 khag7 deleted the khag7:khag7-patch-1 branch Sep 18, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment