Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filter pipeline config files #279

Merged
merged 11 commits into from Aug 30, 2021

Conversation

anbraten
Copy link
Member

@anbraten anbraten commented Aug 28, 2021

closes #271

Done

  • filter pipeline config folders for .yml and .yaml files
  • improve fetchConfig tests
  • update remote mock and correct wrong folder name mock => mocks to match package name
  • fix: return correct filename for fallback
  • improve config loading by checking if folder or not before sending api call

@anbraten anbraten marked this pull request as draft August 28, 2021 17:54
@anbraten anbraten marked this pull request as ready for review August 28, 2021 19:56
@anbraten anbraten changed the title fix: filter multi pipeline files fix: filter pipeline config files Aug 28, 2021
@6543 6543 added the bug Something isn't working label Aug 29, 2021
@6543 6543 added this to the 0.15.0 milestone Aug 29, 2021
@6543
Copy link
Member

6543 commented Aug 30, 2021

@anbraten

--- FAIL: TestFetch (0.02s)
    --- FAIL: TestFetch/Not_found_and_disabled_fallback (0.00s)
        configFetcher_test.go:164: error fetching config File not found
[0xc00028b140 0xc00028b3e0]
FAIL

@6543 6543 merged commit 34cfabb into woodpecker-ci:master Aug 30, 2021
@anbraten anbraten deleted the filter-multi-pipeline-files branch August 30, 2021 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: multipipeline runs on more than .yml files
2 participants