Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Bugfix: eredis_client:stop/1 used to crash the caller process. #14

Merged
merged 1 commit into from

2 participants

Krzysiek Goj Knut Nesheim
Krzysiek Goj

eredis_client:handle_call(stop, _From, State) used to return 3-element tuple, thus not replying to the caller and making it crash when gen_server stopped.

See:

Krzysiek Goj goj Don't crash the caller of eredis_client:stop/1
eredis_client:handle_call(stop, _From, State) used to return
3-element tuple, thus not replying to the caller and making
it crash when gen_server stopped.
a9400f1
Knut Nesheim knutin merged commit 84e1c3f into from
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Oct 20, 2011
  1. Krzysiek Goj

    Don't crash the caller of eredis_client:stop/1

    goj authored
    eredis_client:handle_call(stop, _From, State) used to return
    3-element tuple, thus not replying to the caller and making
    it crash when gen_server stopped.
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  src/eredis_client.erl
2  src/eredis_client.erl
View
@@ -87,7 +87,7 @@ handle_call({request, Req}, From, State) ->
do_request(Req, From, State);
handle_call(stop, _From, State) ->
- {stop, normal, State};
+ {stop, normal, ok, State};
handle_call(_Request, _From, State) ->
{reply, unknown_request, State}.
Something went wrong with that request. Please try again.