Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception code 0 #84

Closed
jakagacic opened this issue May 22, 2019 · 2 comments · Fixed by #85
Closed

Exception code 0 #84

jakagacic opened this issue May 22, 2019 · 2 comments · Fixed by #85

Comments

@jakagacic
Copy link
Contributor

Hi!

Exceptions in namespace WoohooLabs\Yin\JsonApi\Exception don't have correct codes, they all use default code 0, without the possibility of overriding. This makes it harder to handle these errors. For example, FullReplacementProhibited should have code 403.

Libraries like jsonapi bundle, that is commonly used with yours, depend on the code to format errors correctly, so it would be nice to have this fixed.

I could make a PR containing the necessary changes if you agree.

@kocsismate
Copy link
Member

Hi @jakagacic ,

Thanks for the feedback, I'd appreciate a PR. :)

@kocsismate
Copy link
Member

Your changes have just been released! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants