Don’t skip adjacent top-level headings #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eush77
force-pushed
the
adjacent-top-level
branch
from
25cb73e
to
ef30cb4
Compare
wooorm
changed the title
|
Thanks! Could you, in the future, also call |
|
Sure! |
wooorm
added
⛵️ status/released
🐛 type/bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes the issue with iterating over adjacent title headings and removing nodes in
lib/transformer.js.In the example below, as the first heading is removed, the index of the second one becomes
0and the second heading is skipped.titleCount == 1, the depth of the remaining heading remains intact, and it renders to.SScommand.This patch defers AST mutation until the traversal is over.