Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Simple Product - "Virtual" and "Downloadable" Not Autocompleting PayPal #2833

Closed
GratuiTous opened this Issue · 19 comments

2 participants

@GratuiTous

Hey Woocommerce,

I'm using your free Mystile theme.

After the 2.0.4 updated, auto completion of paypal payments have not been working for "Virtual" and "Downloadable" products. I see others are having issues as well about this.

I downgraded to Woocommerce 2.0.3 and everything worked great! So in 2.0.4+ there has been something added to stop the auto complete of virtual + downloadable products?

Here's a link for more info via wordpress forums:
http://wordpress.org/support/topic/orders-not-completing?replies=10

Thanks,
Riley!

@mikejolley
Owner

Could be this? 89b4225

Thats all that should have changed. If you go back to 2.0.5 and apply that fix, we can possibly help debug.

@GratuiTous

Hey Mike,

Thanks for your reply,

I'm not a coder, just so you are aware. I am capable of doing some tweaks here and there, but don't understand the meat of it.

I went into classes/gateways/paypal/class-wc-gateway-paypal.php and changed _ to -> -- then tested payment via paypal sand box.

This was all that 89b4225 was asking right?

It ending up doing the same thing as 2.0.4+ -- only making me do it manually on Virtual and Downloadable products (see image).
pending - manual accept

My test site is:
demo.soundpackflyer.com -- if that helps!

@mikejolley
Owner

on-hold - view the order. See whats in the notes section.

@GratuiTous

no notes

No notes within the order!

Is pending the same as on-hold? -- Cause on mouse hover, the red circle I did in the last image, says "pending"..

@mikejolley
Owner

O pending, sorry, my bad.

Not much else changed from .3 to .5. You could of course enable logging in paypal settings to see what that shows you?

@GratuiTous

As mentioned, I don't really know what I'm doing in the back end -- You gotta be a bit lenient with me ;)

I enabled Paypal logging, purchased another product with sandbox enabled.

Here's the log: (If I'm supposed to post this lol)

03-27-2013 @ 21:45:48 - Generating payment form for order #8843. Notify URL: http://demo.soundpackflyer.com/?wc-api=WC_Gateway_Paypal
03-27-2013 @ 21:46:15 - Checking IPN response is valid...
03-27-2013 @ 21:46:15 - IPN Request: Array
(
[body] => Array
(
[cmd] => _notify-validate
[mc_gross] => 98.00
[invoice] => SPF-8843
[protection_eligibility] => Ineligible
[item_number1] =>
[payer_id] => HL7MV6S683UXW
[tax] => 0.00
[payment_date] => 14:46:12 Mar 27, 2013 PDT
[payment_status] => Pending

@mikejolley
Owner

Are you using w3 total cache by any chance?

@GratuiTous

No, no caching plugin. The site is just in tests at the moment.

I've also tried to disable all the plugins and redo the purchase before changing _ to ->. Same thing!

In that wordpress forum post, others are having the same issue!

I went down to 1.6.6 all the way up to 2.0.3 and they all work great from what I tested! (Auto complete on virtual + downloadable auto completed).

@mikejolley
Owner

O look:

[payment_status] => Pending

Why is PP sending pending? Did you accept the funds?

It won't complete until you do!

@GratuiTous

Well on my paypal account, I have it set up for when someone sends payment, I automatically accept the payment without me having to manually do it.

2.0.3 works great and auto completes, but anything higher (2.0.4+) doesn't?

@GratuiTous

All seems to be working great with 2.0.3.. (From what I've tested).

I'm very happy to use 2.0.3, I just wanted to bring it to your attention. -- Just keep in mind, others are struggling here too!

Thanks Mike,

Let me know if you have any other thoughts,

Riley!

@mikejolley
Owner

Are you using sandbox rather than live?

43cc129

@GratuiTous

Yes I am!

Want me to switch that code, disable sandbox, then try it again by repurchasing, but using my sandbox account @ payment time?

@mikejolley
Owner

1 sec

@GratuiTous

Ok, I'm waiting -- Currently switching out code!

@mikejolley mikejolley referenced this issue from a commit
@mikejolley mikejolley Sandbox fix. #2833 02beffd
@mikejolley
Owner

See the code I just pushed.

Please note, this issue doesn't affect live accounts so when your store is live this won't be a problem anyway.

@GratuiTous

Ok, I added in your code. Keep sandbox enabled while testing?

So you're saying it's only Sandbox that is not allowing the auto complete, the live site will work smoothly with auto complete, hopefully?

@GratuiTous

With your code added and SANDBOX enabled, everything worked great now Mike. :+1:

Now, how can I be confident with the live store.. :question:

@mikejolley
Owner

Live store doesn't return pending - its a sandbox issue.

@mikejolley mikejolley closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.