New 'listtype' variable for $woocommerce_loop and consistent filters for upsell and cross-sell queries #10028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using this plugin authors and theme developers can see what kind of product list is being generated in the loop.
Using this plugin authors and theme developers can see what kind of product list is being generated in the loop.
Using this plugin authors and theme developers can see what kind of product list is being generated in the loop.
Using this plugin authors and theme developers can see what kind of product list is being generated in the loop.
Using this plugin authors and theme developers can see what kind of product list is being generated in the loop.
Using this plugin authors and theme developers can see what kind of product list is being generated in the loop.
There is already a filter in related.php, let plugin authors and theme developers hook into this as well.
There is already a filter in related.php, let plugin authors and theme developers hook into this as well. woocommerce_cross_sells_total should be marked as deprecated
Using this plugin authors and theme developers can see what kind of product list is being generated in the loop.
|
Will review for 2.6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am the developer of the plugin "DuracellTomi's Google Tag Manager for WordPress". While extending the implementation of the Google Analytics Enhanced Ecommerce tracking in my plugin, I found some opportunity to make the code better.
Inconsistent WP filters
There are some inconsistencies in the code:
I modified the codes to use a WP filter for each template for the whole WP query args array.
New variable for the loop
I added a new variable to the $woocommerce_loop array so that during product code generation I and other plugin authors can "see" in the code which type of product list is being generated: general product category, related products, upsells, etc.
I think this will be useful for other plugin authors and theme developers as well.