Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Increase priority so that registered taxonomies are available #2691

Merged
merged 1 commit into from

3 participants

@dgwatkins

We use a rather customize version of woocommerce and we ran into a problem.

In short, we have a custom taxonomy associated to woocommerce products. This taxonomy was created with the Types plugin:
http://wordpress.org/extend/plugins/types/

The problem is that Types is registering the custom taxonomy as priority 10 in the 'init' hook, as explained here:
http://codex.wordpress.org/Function_Reference/register_taxonomy

But checkout is also being fired by woocommerce at 'init' with priority 10, this causes any filters that we attach to woocommerce_checkout_complete to not have the custom taxonomies available.

With this commit, its all working as we expect it. Would it be possible to incorporate?

@leewillis77

Can't you re-queue either the types hook or the WC ones in your own code by using remove_action and re-adding it with a priority that suits? This change could conceivable break other people's code who are assuming WC completes it's work at priority 10 (Although I guess that's probably unlikely)

@mikejolley
Owner

I scanned all of our extensions and found none changing priorities of those two actions. I will merge, but then move the priority to 20.

@mikejolley mikejolley merged commit dca38e9 into from
@mikejolley mikejolley referenced this pull request from a commit
@mikejolley mikejolley Priority 20 #2691 6dadf2f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 2 deletions.
  1. +2 −2 woocommerce-hooks.php
View
4 woocommerce-hooks.php
@@ -248,8 +248,8 @@
* @see woocommerce_checkout_action()
* @see woocommerce_pay_action()
*/
-add_action( 'init', 'woocommerce_checkout_action', 10 );
-add_action( 'init', 'woocommerce_pay_action', 10 );
+add_action( 'init', 'woocommerce_checkout_action', 11 );
+add_action( 'init', 'woocommerce_pay_action', 11 );
/**
* Login and Registration
Something went wrong with that request. Please try again.