Skip to content

Schema Filter for downloadable products. #3297

Closed
wants to merge 7 commits into from

4 participants

@seb86
seb86 commented Jun 7, 2013

This is for filtering the schema data for downloadable products. This will allow developers to further expand extension ideas.

@coenjacobs

See #3295 for a detailed description.

@mikejolley
WooThemes member

Interesting. Ill need to look at this one in more depth. Might be better to have a get_schema method rather than a hooked in template?

@seb86
seb86 commented Jun 10, 2013

Ok great. The code I submitted was written quickly to show an example of the possibilities. If there is a better way to put this in place, i'm all ears.

@coenjacobs

Just a quick note: This needs a default value (even for downloadable products) that will use the default schema output. This will be used for downloads that don't fit in a specific download type (or when not set).

@seb86
seb86 commented Jun 11, 2013

I have tested the code and it works on my end. Please verify. This would be great if it was added for the next release. Thanks.

@douglance

It'd be great to be able to filter available downloads for people based on date of their sign-up, i.e. digital magazine subscriptions.

@seb86
seb86 commented Jun 19, 2013

Can you explain a little more about how that would be part of the schema @douglance Thanks.

@seb86
seb86 commented Aug 20, 2013

So is this now merged @mikejolley ?

@mikejolley
WooThemes member

Sort of, it wouldn't mege automatically due to recent changes so I put my take on it. Rather than having a template file, I've just added a function to the actual itemscope param

@seb86
seb86 commented Aug 20, 2013

@mikejolley It looks good. Will I still be credited for this feature ?

@mikejolley
WooThemes member

@seb86 I didn't merge it, so it won't show you on github.

@seb86
seb86 commented Aug 20, 2013

@mikejolley oh :( Will I still be named in the readme.txt file then ?

@coenjacobs

@seb86 Nobody is mentioned in the readme.txt file, you can just have your name in the contributors list (also shown in welcome screen of the plugin) if your patch is merged in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.