프로필 및 커버 사진업로드 구현 #92
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 프로필, 커버사진 업로드를 위한 서비스 클래스 생성 (UserImageUploadService) - 프로필, 커버를 구별하는 enum UploadType - ImageUploader 함수형 인터페이스로 업로드 구현 - 유저의 이미지를 받는 Dto UploadImage - UploadType enum을 String에서 변환해주는 UploadTypeConverter 구현 및 등록
- 마이페이지 전용 Dto MyPageResponse 추가 - 친구 정보를 가져오는 jpql 추가 (findFriendsByUserId) - 내가 올린 사진 정보 가져오는 쿼리 메서드 추가 (findByOwnerId)
…s-2019 into feature/profile # Conflicts: # src/main/java/com/wootecobook/turkey/user/controller/UserApiController.java # src/main/java/com/wootecobook/turkey/user/service/UserService.java # src/main/resources/static/css/mypage.css # src/main/resources/static/js/mypage/mypage.js # src/main/resources/static/js/mypage/template.js
- 친구의 정보를 가져오는 JPQL 테스트 - 프로필 및 커버 사진 업로드 테스트
yk1028
approved these changes
Aug 29, 2019
| import com.wootecobook.turkey.user.service.UploadType; | ||
| import org.springframework.core.convert.converter.Converter; | ||
|
|
||
| public class UploadTypeConverter implements Converter<String, UploadType> { |
There was a problem hiding this comment.
이름이 조금 햇갈리는것 같아요. 이미지를 구분하는 것이니 ImageTypeConverter 같은 이름도 좋을거 같아요.
| public boolean existsById(final Long id) { | ||
| return userRepository.existsById(id); | ||
|
|
| private List<UserResponse> friends; | ||
|
|
||
| @Builder | ||
| public MyPageResponse(final UserResponse user, final FileFeature cover, final List<FileFeature> images, final List<UserResponse> friends) { |
| @@ -0,0 +1,83 @@ | |||
| const UPLOAD_URL = (userId) => `/api/users/${userId}/upload` | |||
yk1028
reviewed
Aug 29, 2019
| } | ||
|
|
||
| @GetMapping("/{id}") | ||
| public ResponseEntity<UserResponse> show(@PathVariable Long id) { | ||
| return ResponseEntity.ok(userService.findUserResponseById(id)); | ||
| public ResponseEntity<MyPageResponse> show(@PathVariable Long id) { |
There was a problem hiding this comment.
기존것 이외에 아래처럼 새로운 메서드를 하나 만드는게 어떨까요? url만 보면 혼란스러울 수 있을것 같아요.
@GetMapping("/{id}/mypage")
public ResponseEntity<MyPageResponse> show(@PathVariable Long id) {
return ResponseEntity.ok(myPageService.findUserResponseById(id));
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
현재 제 컴퓨터에서 S3에 접근이 불가해 실제로 Profile과 Cover 사진 업로드가 제대로 되는지는 확인 못했습니다. 확인 부탁드려요 ㅎㅎ
현재 Upload를 UploadType이라는 enum에서 해주고 있어요. 구조가 맞게 이뤄졌는지 여러분의 의견도 궁금합니다. *(UploadType의 이름이 적절하지 않은 것 같기도하네요...) 확인부탁드려요!
resolved #33 #68 #87