[1-2단계 Tomcat 구현하기] 산초(나영서) 미션 제출합니다. #573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 우테코 컨벤션에 맞게
tsulocalize
approved these changes
Sep 7, 2024
tsulocalize
left a comment
tsulocalize
left a comment
There was a problem hiding this comment.
전반적으로 잘 구현해주신 것 같아 간단한 코멘트만 남기고 Approve & Merge 하겠습니다!
| return headers.get("Content-Type"); | ||
| } | ||
|
|
||
| public Map<String, String> getCookies() { |
Comment on lines
+30
to
+32
| String url = request | ||
| .split(System.lineSeparator())[0] | ||
| .split(" ")[1]; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 우주🛸
이번 톰캣 구현하기 미션의 리뷰이인 산초입니다.
리뷰를 하시며 참고할 부분들을 아래 적어두었습니다.
그럼 리뷰 미리 감사드립니다🙇🏻♀️
Dispatcher Servlet 의 구조를 참고해서 구현했습니다.
처음부터 이를 의도한 것은 아니었습니다.. 하지만 단계가 높아짐에 따라 요청을 어떻게 처리할지 어려웠고, 제게 가장 익숙한 Dispatcher Servlet의 구조를 참고하며 구현했습니다. 그런데 '톰캣 구현하기'가 목표이니, 이런 접근이 좋지 않았다는 생각이 듭니다😔 다음에 리팩터링할 때는, 웹서버와 웹 어플리케이션 서버를 더 확실히 구분하고, 패키지나 클래스도 톰캣의 구조를 따로도록 바꿔보고 싶습니다.