[1,2단계 - Tomcat 구현하기] 몰리(김지민) 미션 제출합니다. #582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…디를 key, value로 파싱하는 책임 부
jminkkk
commented
Sep 10, 2024
Author
jminkkk
left a comment
jminkkk
left a comment
There was a problem hiding this comment.
안녕하세요 산초
좋은 피드백 감사합니다 🔥
분리한 패키지에 대해 간단히 설명을 하자면
- http
- http protocol에서 사용되는 컴포넌트들
- coyote
- http 기반의 요청을 받고, 처리하는 객체들
- catalina
- 특정 프로토콜에 종속되지 않은 was 실행 객체
+) 테스트 추가와 리팩토링을 하다보니 반영이 너무 늦어졌네요 ㅠ
Response 객체 분리와 Controller, HttpMethod Enum 분리 등은 다음 단계에서 진행해보려고 추가하지 않았으니 참고 부탁드립니다!
nayonsoso
approved these changes
Sep 10, 2024
nayonsoso
left a comment
nayonsoso
left a comment
There was a problem hiding this comment.
열심히 리팩터링해주셨네요
완성도가 느껴지는 코드가 된 것 같아요 ㅎㅎ
이번 미션은 휼륭히 하신 것 같으니 이만 머지하겠습니다🤩
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 산초! 몰리입니다 🍀
전체적인 프로세스로 동작하도록 했습니다...!
요청 -> HandlerMapping -> RequestHandler -> 응답시간 관계상 코드가 친절하지 못해서 양해부탁드립니다 ...😭