New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable bouncing when customTabs shows #397

Merged
merged 1 commit into from Feb 8, 2018

Conversation

Projects
None yet
2 participants
@isaacjoe
Contributor

isaacjoe commented Feb 7, 2018

After ionic v3, when setting deafult page as customTabs, when scroll over page to top or bottom will happen boucing.
insert no-bounce to tabs.html in to will disable bouncing if cordova confin.xml not help the feature.

Signed-off-by: isaac im.isaacjoe@gmail.com

Disable bouncing when customTabs shows
After ionic v3, when setting deafult page as customTabs, when scroll over page to top or bottom will happen boucing.
insert no-bounce to tabs.html in <ion-content> to <ion-content no-bounce> will disable bouncing if cordova confin.xml not help the feature.

Signed-off-by: isaac <im.isaacjoe@gmail.com>
@shprink

This comment has been minimized.

Collaborator

shprink commented Feb 7, 2018

Thanks for the PR but what's wrong with the bouncing?

@isaacjoe

This comment has been minimized.

Contributor

isaacjoe commented Feb 8, 2018

Hi shprink:
It happen on iOS when select TABS from left menu, or set default page as customTabs in config.cson. Please refer the GIF. Thanks for the project. it helpful. :-)
no-bounce

@shprink shprink merged commit 9ae02cf into wordpress-clients:develop Feb 8, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@shprink

This comment has been minimized.

Collaborator

shprink commented Feb 8, 2018

I got it now :) thanks

@isaacjoe isaacjoe deleted the isaacjoe:disable-bouncing branch Mar 5, 2018

@isaacjoe isaacjoe restored the isaacjoe:disable-bouncing branch Mar 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment