Add UI Tests for Simple Text Formatting

[rachelmcr]

This PR adds a suite of UI tests for simple text formatting in the Aztec demo app, using the Android Espresso testing framework.

Before running the tests

Espresso advises disabling system animations on devices used for testing:

On your device, under Settings->Developer options disable the following 3 settings:

• Window animation scale
• Transition animation scale
• Animator duration scale

One additional setup step is also required to handle an Espresso issue with clicks (see the caveats below):

On your device, under Settings -> Accessibility -> Touch & hold delay, set the delay to Long.

Test Details

Each test performs the following steps:

1. Enter text (unformatted).
2. Select a formatting button in the toolbar.
3. Enter more text (with formatting).
4. Verify the correct HTML appears in HTML mode for the unformatted and formatted text.

A couple caveats:

• The Espresso framework sometimes performs a long click instead of a single click (see the Espresso code for an explanation). In the Aztec toolbar, this displays a hint instead of selecting the formatting button and causes the test to fail.
• Espresso also has trouble with the editor's link dialog. Although it can identify the fields and buttons in the dialog (and TalkBack works with the dialog as expected) it clicks in the wrong position. This seems to be a bug with the coordinates select for the click action for a custom AlertDialog and so I reversed the link formatting test. (It enters the link HTML and then verifies that the link dialog displays the expected values.)

cc @catehstn @lancewillett @hoverduck

[rachelmcr]

I just edited the original description to add a setup step for changing the "Touch & hold delay" setting to Long on the device used for testing. I'd forgotten this step earlier, but it should resolve most issues with the click turning into a long click in these tests (phones and tablets).

I do want to note that I observed a persistent problem with the click turning into a long click if the formatting button was selected as the first step in the test (before adding any text to the editor). That could indicate a potential performance issue when Aztec is first launched, and I went ahead and opened an issue to track that: #383

[rachelmcr]

I just edited the original description to add a setup step for changing the "Touch & hold delay" setting to Long on the device used for testing. I'd forgotten this step earlier, but it should resolve most issues with the click turning into a long click in these tests (phones and tablets).

I do want to note that I observed a persistent problem with the click turning into a long click if the formatting button was selected as the first step in the test (before adding any text to the editor). That could indicate a potential performance issue when Aztec is first launched, and I went ahead and opened an issue to track that: #383

[catehstn]

This looks great!

[catehstn]

What's the 65 for? Does this relate to the comment at the top?

[rachelmcr]

Yes, the 65 here is a percentage: The default ClickAction in Espresso checks to make sure at least 90% of the element is displayed on-screen before clicking on it. The 65 here checks to make sure at least 65% of the element is displayed on-screen instead.

[catehstn]

NL @ EOF

[catehstn]

😍

[catehstn]

Nice that we can have proper strings in Android - unlike iOS! :)

[catehstn]

why is there a \t here?

[rachelmcr]

The \t indents the list item on screen.

[catehstn]

I think don't comment out a test if you've replaced it - instead probably add a comment inside the other one noting why it's tested that way and not this.

[catehstn]

@0nko ptal - if you're happy let's merge it.

[catehstn]

@0nko ptal - if you're happy let's merge it.

[hoverduck]

@rachelmcr I finally got a chance to get my Android dev environment set back up and take a look. Everything checks out 👍 !

My only comment is that you should probably include an update to the README to provide the "Before running the tests" setup steps from the PR details. Is there maybe a way to automate those steps via a set of ADB commands prior to starting the tests?

[hoverduck]

@rachelmcr I finally got a chance to get my Android dev environment set back up and take a look. Everything checks out 👍 !

My only comment is that you should probably include an update to the README to provide the "Before running the tests" setup steps from the PR details. Is there maybe a way to automate those steps via a set of ADB commands prior to starting the tests?

[0nko]

After following the device configuration steps the tests pass. I'll add these to the README, like @hoverduck suggested.

Quickly searching for the adb commands I did find something for disabling the animations:

adb shell content update --uri content://settings/system --bind value:s:0.0 --where 'name="window_animation_scale"'
adb shell content update --uri content://settings/system --bind value:s:0.0 --where 'name="transition_animation_scale"'
adb shell content update --uri content://settings/system --bind value:s:0.0 --where 'name="animator_duration_scale"'

And for setting a long tap delay:

adb shell settings put secure long_press_timeout <time in ms>

I haven't tested them, though. @rachelmcr, thank you so much for setting up the test environment and writing these!

[0nko]

After following the device configuration steps the tests pass. I'll add these to the README, like @hoverduck suggested.

Quickly searching for the adb commands I did find something for disabling the animations:

adb shell content update --uri content://settings/system --bind value:s:0.0 --where 'name="window_animation_scale"'
adb shell content update --uri content://settings/system --bind value:s:0.0 --where 'name="transition_animation_scale"'
adb shell content update --uri content://settings/system --bind value:s:0.0 --where 'name="animator_duration_scale"'

And for setting a long tap delay:

adb shell settings put secure long_press_timeout <time in ms>

I haven't tested them, though. @rachelmcr, thank you so much for setting up the test environment and writing these!

[0nko]

[0nko]