From d06fadb3e534dececfd596cee2910f076da3c0d7 Mon Sep 17 00:00:00 2001 From: Gio Lodi Date: Mon, 16 Jun 2025 14:17:05 +1000 Subject: [PATCH] Add explanatory comments to the conditional HTMLParser imports --- .../BoldElementAttributeConverterTests.swift | 4 ++++ .../ItalicElementAttributeConverterTests.swift | 1 + .../UnderlineElementAttributeConverterTests.swift | 1 + .../BoldStringAttributeConverterTests.swift | 1 + .../ItalicStringAttributeConverterTests.swift | 1 + Tests/AztecTests/Importer/InAttributeConverterTests.swift | 1 + Tests/AztecTests/Importer/InNodeConverterTests.swift | 1 + .../Conversions/AttributedStringSerializerTests.swift | 1 + Tests/HTMLParserTests/HTML/Conversions/CSSParserTests.swift | 1 + .../HTML/Conversions/DefaultHTMLSerializerTests.swift | 1 + Tests/HTMLParserTests/HTML/Conversions/HTMLParserTests.swift | 1 + Tests/HTMLParserTests/HTML/Nodes/ElementNodeTests.swift | 1 + Tests/HTMLParserTests/HTML/Nodes/TextNodeTests.swift | 1 + 13 files changed, 16 insertions(+) diff --git a/Tests/AztecTests/Converters/AttributesToStringAttributes/BoldElementAttributeConverterTests.swift b/Tests/AztecTests/Converters/AttributesToStringAttributes/BoldElementAttributeConverterTests.swift index 1b2158013..4ec92065b 100644 --- a/Tests/AztecTests/Converters/AttributesToStringAttributes/BoldElementAttributeConverterTests.swift +++ b/Tests/AztecTests/Converters/AttributesToStringAttributes/BoldElementAttributeConverterTests.swift @@ -1,5 +1,9 @@ import XCTest @testable import Aztec +// This test exercises sources from the Aztec target, but also uses internal APIs from HTMLParser. +// +// The HTMLParser target exists only when building for Swift package manager. +// Otherwise, such as when building via CocoaPods, its sources are part of Aztec. #if SWIFT_PACKAGE @testable import HTMLParser #endif diff --git a/Tests/AztecTests/Converters/AttributesToStringAttributes/ItalicElementAttributeConverterTests.swift b/Tests/AztecTests/Converters/AttributesToStringAttributes/ItalicElementAttributeConverterTests.swift index 3d4ebc8c2..e96b3db93 100644 --- a/Tests/AztecTests/Converters/AttributesToStringAttributes/ItalicElementAttributeConverterTests.swift +++ b/Tests/AztecTests/Converters/AttributesToStringAttributes/ItalicElementAttributeConverterTests.swift @@ -1,5 +1,6 @@ import XCTest @testable import Aztec +// See comment in BoldElementToAttributeConverterTests.swift to understand the conditional import below. #if SWIFT_PACKAGE @testable import HTMLParser #endif diff --git a/Tests/AztecTests/Converters/AttributesToStringAttributes/UnderlineElementAttributeConverterTests.swift b/Tests/AztecTests/Converters/AttributesToStringAttributes/UnderlineElementAttributeConverterTests.swift index 9e37913a6..2feea7a00 100644 --- a/Tests/AztecTests/Converters/AttributesToStringAttributes/UnderlineElementAttributeConverterTests.swift +++ b/Tests/AztecTests/Converters/AttributesToStringAttributes/UnderlineElementAttributeConverterTests.swift @@ -1,5 +1,6 @@ import XCTest @testable import Aztec +// See comment in BoldElementToAttributeConverterTests.swift to understand the conditional import below. #if SWIFT_PACKAGE @testable import HTMLParser #endif diff --git a/Tests/AztecTests/Converters/StringAttributesToAttributes/BoldStringAttributeConverterTests.swift b/Tests/AztecTests/Converters/StringAttributesToAttributes/BoldStringAttributeConverterTests.swift index 71a93e293..e37bba95f 100644 --- a/Tests/AztecTests/Converters/StringAttributesToAttributes/BoldStringAttributeConverterTests.swift +++ b/Tests/AztecTests/Converters/StringAttributesToAttributes/BoldStringAttributeConverterTests.swift @@ -1,5 +1,6 @@ import XCTest @testable import Aztec +// See comment in BoldElementToAttributeConverterTests.swift to understand the conditional import below. #if SWIFT_PACKAGE @testable import HTMLParser #endif diff --git a/Tests/AztecTests/Converters/StringAttributesToAttributes/ItalicStringAttributeConverterTests.swift b/Tests/AztecTests/Converters/StringAttributesToAttributes/ItalicStringAttributeConverterTests.swift index 824154ce3..149811e3b 100644 --- a/Tests/AztecTests/Converters/StringAttributesToAttributes/ItalicStringAttributeConverterTests.swift +++ b/Tests/AztecTests/Converters/StringAttributesToAttributes/ItalicStringAttributeConverterTests.swift @@ -1,5 +1,6 @@ import XCTest @testable import Aztec +// See comment in BoldElementToAttributeConverterTests.swift to understand the conditional import below. #if SWIFT_PACKAGE @testable import HTMLParser #endif diff --git a/Tests/AztecTests/Importer/InAttributeConverterTests.swift b/Tests/AztecTests/Importer/InAttributeConverterTests.swift index c951262b4..f67d29d02 100644 --- a/Tests/AztecTests/Importer/InAttributeConverterTests.swift +++ b/Tests/AztecTests/Importer/InAttributeConverterTests.swift @@ -1,5 +1,6 @@ import XCTest import libxml2 +// See comment in BoldElementToAttributeConverterTests.swift to understand the conditional import below. #if SWIFT_PACKAGE @testable import HTMLParser #else diff --git a/Tests/AztecTests/Importer/InNodeConverterTests.swift b/Tests/AztecTests/Importer/InNodeConverterTests.swift index 78151dfe4..f8f01d7a2 100644 --- a/Tests/AztecTests/Importer/InNodeConverterTests.swift +++ b/Tests/AztecTests/Importer/InNodeConverterTests.swift @@ -1,5 +1,6 @@ import XCTest import libxml2 +// See comment in BoldElementToAttributeConverterTests.swift to understand the conditional import below. #if SWIFT_PACKAGE @testable import HTMLParser #else diff --git a/Tests/AztecTests/NSAttributedString/Conversions/AttributedStringSerializerTests.swift b/Tests/AztecTests/NSAttributedString/Conversions/AttributedStringSerializerTests.swift index ad719d0ab..4fdfe3891 100644 --- a/Tests/AztecTests/NSAttributedString/Conversions/AttributedStringSerializerTests.swift +++ b/Tests/AztecTests/NSAttributedString/Conversions/AttributedStringSerializerTests.swift @@ -1,5 +1,6 @@ import XCTest @testable import Aztec +// See comment in BoldElementToAttributeConverterTests.swift to understand the conditional import below. #if SWIFT_PACKAGE @testable import HTMLParser #endif diff --git a/Tests/HTMLParserTests/HTML/Conversions/CSSParserTests.swift b/Tests/HTMLParserTests/HTML/Conversions/CSSParserTests.swift index c28095580..1972d0fb5 100644 --- a/Tests/HTMLParserTests/HTML/Conversions/CSSParserTests.swift +++ b/Tests/HTMLParserTests/HTML/Conversions/CSSParserTests.swift @@ -1,4 +1,5 @@ import XCTest +// See comment in BoldElementToAttributeConverterTests.swift to understand the conditional import below. #if SWIFT_PACKAGE @testable import HTMLParser #else diff --git a/Tests/HTMLParserTests/HTML/Conversions/DefaultHTMLSerializerTests.swift b/Tests/HTMLParserTests/HTML/Conversions/DefaultHTMLSerializerTests.swift index a0f8cb61e..1df84918b 100644 --- a/Tests/HTMLParserTests/HTML/Conversions/DefaultHTMLSerializerTests.swift +++ b/Tests/HTMLParserTests/HTML/Conversions/DefaultHTMLSerializerTests.swift @@ -1,4 +1,5 @@ import XCTest +// See comment in BoldElementToAttributeConverterTests.swift to understand the conditional import below. #if SWIFT_PACKAGE @testable import HTMLParser #else diff --git a/Tests/HTMLParserTests/HTML/Conversions/HTMLParserTests.swift b/Tests/HTMLParserTests/HTML/Conversions/HTMLParserTests.swift index 445f709b7..e867d073e 100644 --- a/Tests/HTMLParserTests/HTML/Conversions/HTMLParserTests.swift +++ b/Tests/HTMLParserTests/HTML/Conversions/HTMLParserTests.swift @@ -1,4 +1,5 @@ import XCTest +// See comment in BoldElementToAttributeConverterTests.swift to understand the conditional import below. #if SWIFT_PACKAGE @testable import HTMLParser #else diff --git a/Tests/HTMLParserTests/HTML/Nodes/ElementNodeTests.swift b/Tests/HTMLParserTests/HTML/Nodes/ElementNodeTests.swift index d5c9acd5e..44d079bf9 100644 --- a/Tests/HTMLParserTests/HTML/Nodes/ElementNodeTests.swift +++ b/Tests/HTMLParserTests/HTML/Nodes/ElementNodeTests.swift @@ -1,4 +1,5 @@ import XCTest +// See comment in BoldElementToAttributeConverterTests.swift to understand the conditional import below. #if SWIFT_PACKAGE @testable import HTMLParser #else diff --git a/Tests/HTMLParserTests/HTML/Nodes/TextNodeTests.swift b/Tests/HTMLParserTests/HTML/Nodes/TextNodeTests.swift index 8024e6ddd..269f87768 100644 --- a/Tests/HTMLParserTests/HTML/Nodes/TextNodeTests.swift +++ b/Tests/HTMLParserTests/HTML/Nodes/TextNodeTests.swift @@ -1,4 +1,5 @@ import XCTest +// See comment in BoldElementToAttributeConverterTests.swift to understand the conditional import below. #if SWIFT_PACKAGE @testable import HTMLParser #else