Skip to content

task: Log network activity #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Dec 1, 2025
Merged

task: Log network activity #238

merged 24 commits into from
Dec 1, 2025

Conversation

@dcalhoun
Copy link
Member

@dcalhoun dcalhoun commented Nov 21, 2025 •
edited
Loading

What?

Allow logging network activity occurring in the WebView.

Why?

Improve observability and debugging of editor network activity.

How?

  • Add an editor configuration option for toggling network logging.
  • Conditionally override global window.fetch to intercept network activity.
  • Add utility methods for communicating activity from JavaScript to native host apps.

Testing Instructions

  1. Run the demo app.
  2. Perform actions in the editor.
  3. Verify the network activity is logged in the Xcode/Android Studio IDE.

Accessibility Testing Instructions

N/A, no user-facing changes.

Screenshots or screencast

N/A, no user-facing changes.

@dcalhoun dcalhoun added the [Type] Task Issues or PRs that have been broken down into an individual action to take label Nov 21, 2025
@dcalhoun dcalhoun marked this pull request as ready for review November 21, 2025 21:35
@dcalhoun dcalhoun requested a review from jkmassel November 21, 2025 21:38
@dcalhoun dcalhoun force-pushed the feat/log-network-activity branch from aa07850 to eac9a47 Compare November 24, 2025 21:37
jkmassel
jkmassel approved these changes Nov 27, 2025
View reviewed changes
Copy link
Contributor

@jkmassel jkmassel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well on iOS – adding @oguzkocer as a reviewer for Android to confirm that all the data is present there.

@jkmassel jkmassel requested a review from oguzkocer November 27, 2025 18:46
@oguzkocer
Copy link
Contributor

oguzkocer commented Nov 27, 2025

@jkmassel I've tested this in WPAndroid Chucker integration and it worked well. The only missing bit was the status text, which is relatively easy to map from the status code, so I think it's fine to land as is.

Note that I didn't review the implementation. Let me know if that's needed.

@dcalhoun
Copy link
Member Author

dcalhoun commented Dec 1, 2025

The only missing bit was the status text, which is relatively easy to map from the status code, so I think it's fine to land as is.

@oguzkocer I'll add the status text today. If you you'd like me to rename anything, please share suggestions on the changes in this pull request. I'm happy to follow up and make adjustments.

@oguzkocer
Copy link
Contributor

oguzkocer commented Dec 1, 2025

@oguzkocer I'll add the status text today. If you you'd like me to rename anything, please share suggestions on the changes in this pull request. I'm happy to follow up and make adjustments.

Thanks @dcalhoun! I've added a suggestion, but as I mentioned it should be OK to land as is.

dcalhoun added 20 commits December 1, 2025 11:00
@dcalhoun
task: Add onNetworkRequest bridge utility
1b2a101
@dcalhoun
docs: Direct Claude to format and lint code
16a8d21
@dcalhoun
task: Add fetch override utility
878883d
@dcalhoun
refactor: Avoid overriding fetch if network logging is disabled
4095745
@dcalhoun
refactor: Sort functions by usage occurrence
b31ba88
@dcalhoun
docs: Direct Claude to order functions by usage occurrence
1042b42 
Make reading files easier, encountering high-level logic first before
the implementation details of helper utilities.
@dcalhoun
task: Initialize fetch interceptor
48cf4bc
@dcalhoun
task: Add network logging configuration option
94408e0
@dcalhoun
task: Add iOS network logging delegate methods
a69ac32
@dcalhoun
task: Add Android network logging delegate methods
d6a9ba3
@dcalhoun
task: Enable networking logging in the iOS demo app
b050a4f
@dcalhoun
task: Enable networking logging in the Android demo app
508e431
@dcalhoun
fix: Prevent logging logic locking the Android response
52f64e0 
All requests were failing due to the blocking processing of the body.
@dcalhoun
fix: Custom bridge method sends expected Android data
316bb7f 
The data structure for networking logging is incompatible with
`dispatchToBridge`.
@dcalhoun
fix: Retain values during toBuilder conversion
2ba5083 
The absence of these keys resulted in resetting the value to its default
when converting the configuration to a builder.
@dcalhoun
test: Assert configuration builder properties
5014e2a
@dcalhoun
fix: Serialize various request body types
e153435 
Avoid logging `[Object object]` string values.
@dcalhoun
refactor: Organize fetch interceptor tests
4606526
@dcalhoun
refactor: Extract async logging test helper
2fde120
@dcalhoun
refactor: Prefer Vitest utilities over mock call extraction
d911eb3 
Improve assertion explicitness.
@dcalhoun dcalhoun force-pushed the feat/log-network-activity branch from eac9a47 to e90a418 Compare December 1, 2025 16:10
@dcalhoun
Copy link
Member Author

dcalhoun commented Dec 1, 2025

Added the response status text in e90a418. I rebased this atop the latest trunk branch to address merge conflicts.

I will update the WordPress-iOS implementation for the latest changes.

@oguzkocer I presume you'll update the WordPress-Android implementation for the latest GutnebergKit changes, but let me know if you'd like me to handle it.

@oguzkocer
Copy link
Contributor

oguzkocer commented Dec 1, 2025

@dcalhoun The WPAndroid changes are in a branch, so please feel free to land this and possibly cut a release, and I'll handle that side of the changes.

@dcalhoun dcalhoun merged commit b961a9a into trunk Dec 1, 2025
11 checks passed
@dcalhoun dcalhoun deleted the feat/log-network-activity branch December 1, 2025 17:16
@dcalhoun
Copy link
Member Author

dcalhoun commented Dec 1, 2025

I published these changes and others in the v0.11.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oguzkocer oguzkocer oguzkocer left review comments

@jkmassel jkmassel jkmassel approved these changes

Assignees

No one assigned

Labels

[Type] Task Issues or PRs that have been broken down into an individual action to take

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dcalhoun @oguzkocer @jkmassel