This repository was archived by the owner on Jun 19, 2025. It is now read-only.
Update video cell appearance #203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frosty
reviewed
Aug 16, 2017
| - (void)setCaption:(NSString *)caption | ||
| { | ||
| self.captionLabel.hidden = !(caption.length > 0); | ||
| BOOL hide = !(caption.length > 0); |
Contributor
There was a problem hiding this comment.
Can you just do caption.length <= 0?
frosty
reviewed
Aug 16, 2017
| _captionLabel.backgroundColor = [UIColor colorWithWhite:0.2 alpha:0.7]; | ||
| CGFloat labelTextSize = 12.0; | ||
| CGFloat labelHeight = 30.0; | ||
| CGFloat labelMargin = 5.0; |
Contributor
There was a problem hiding this comment.
I think according to the designs the label should be 10pt from the right edge and bottom, not 5.
frosty
suggested changes
Aug 16, 2017
Contributor
frosty
left a comment
frosty
left a comment
There was a problem hiding this comment.
Looks great, @SergioEstevao! The only change I think is needed to match the designs is that the label should be 10pt from the edges?
Contributor
Author
|
@frosty update according to your comments. |
!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #202
Note: this PR doesn't change the position/selection indicator that will a separate PR
To test: