Skip to content
This repository was archived by the owner on Jun 19, 2025. It is now read-only.

Defer selection of new capture asset to next refresh. #214

Merged
merged 1 commit into from
Aug 24, 2017
Merged

Defer selection of new capture asset to next refresh. #214

merged 1 commit into from
Aug 24, 2017

Conversation

@SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Aug 24, 2017

Fixes #213

To test:

  • Start on the demo app
  • Start the picker by tapping +
  • Go to the camera roll
  • Tap on the capture header
  • Capture a new photo or video
  • Check if when going back to the picker the animation is done correctly.

@SergioEstevao SergioEstevao added this to the 0.20 milestone Aug 24, 2017
@bummytime
Copy link
Contributor

bummytime commented Aug 24, 2017

Reviewed this one pretty well @SergioEstevao. The selection and its animation work great. Code looks square. :shipit:

Nice job!

@SergioEstevao SergioEstevao merged commit 10954ec into develop Aug 24, 2017
@SergioEstevao SergioEstevao deleted the issue/213_fix_selection_on_first_capture branch August 24, 2017 19:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@bummytime bummytime bummytime approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

0.20

Development

Successfully merging this pull request may close these issues.

3 participants

@SergioEstevao @bummytime