This repository was archived by the owner on Jun 19, 2025. It is now read-only.
Adjust placement of empty view while searching #309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…C differently if actively searching.
This was referenced Sep 19, 2018
Contributor
Author
|
Hey @jklausa . Would you mind doing this with wordpress-mobile/WordPress-iOS#10179? They are linked, and this is a small change. Thank you!! |
jklausa
approved these changes
Sep 20, 2018
|
Looks good! :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #wordpress-mobile/WordPress-iOS#10178
With the above WPiOS change, a search with no results displays a different empty view. This adjusts the placement of the empty view if a search is being performed.
To test: