From 54e990786087d726ee0d8582ac8428a2b14e2368 Mon Sep 17 00:00:00 2001 From: Nick Bradbury Date: Mon, 26 Jan 2015 14:32:20 -0500 Subject: [PATCH] Theme live preview no longer changes the activity title --- .../android/util/WPWebChromeClient.java | 28 +++++++++++++------ 1 file changed, 20 insertions(+), 8 deletions(-) diff --git a/WordPressUtils/src/main/java/org/wordpress/android/util/WPWebChromeClient.java b/WordPressUtils/src/main/java/org/wordpress/android/util/WPWebChromeClient.java index 6a40c6f3807b..6d640fc3f27a 100644 --- a/WordPressUtils/src/main/java/org/wordpress/android/util/WPWebChromeClient.java +++ b/WordPressUtils/src/main/java/org/wordpress/android/util/WPWebChromeClient.java @@ -7,23 +7,35 @@ import android.widget.ProgressBar; public class WPWebChromeClient extends WebChromeClient { - private ProgressBar mProgressBar; - private Activity mActivity; + private final ProgressBar mProgressBar; + private final Activity mActivity; + private final boolean mAutoUpdateActivityTitle; public WPWebChromeClient(Activity activity, ProgressBar progressBar) { + mActivity = activity; mProgressBar = progressBar; + mAutoUpdateActivityTitle = true; + } + + public WPWebChromeClient(Activity activity, + ProgressBar progressBar, + boolean autoUpdateActivityTitle) { mActivity = activity; + mProgressBar = progressBar; + mAutoUpdateActivityTitle = autoUpdateActivityTitle; } public void onProgressChanged(WebView webView, int progress) { - if (!mActivity.isFinishing()) { + if (mActivity != null && !mActivity.isFinishing() && mAutoUpdateActivityTitle) { mActivity.setTitle(webView.getTitle()); } - if (progress == 100) { - mProgressBar.setVisibility(View.GONE); - } else { - mProgressBar.setVisibility(View.VISIBLE); - mProgressBar.setProgress(progress); + if (mProgressBar != null) { + if (progress == 100) { + mProgressBar.setVisibility(View.GONE); + } else { + mProgressBar.setVisibility(View.VISIBLE); + mProgressBar.setProgress(progress); + } } } } \ No newline at end of file