Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Previews and labels for Stats widgets #10122

Conversation

@planarvoid
Copy link
Contributor

commented Jun 28, 2019

This PR adds preview images and correct labels for widgets. These images/labels are visible when you try to add a widget.

As part of this PR I'm also updating the release notes and replacing posts with likes in the Today's widget.

Design specs:
Screenshot 2019-06-28 at 09 53 29

Result:
Screenshot 2019-06-28 at 09 58 49
Screenshot 2019-06-28 at 09 58 34

To test:

  • Try to add a widget
  • Notice that the labels and previews are updated according to the specs
  • Add Today's widget
  • Notice it shows likes instead of posts

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@planarvoid planarvoid added this to the 12.8 milestone Jun 28, 2019

@planarvoid planarvoid requested a review from malinajirka Jun 28, 2019

@planarvoid planarvoid self-assigned this Jun 28, 2019

@malinajirka
Copy link
Contributor

left a comment

Thanks @planarvoid! The code looks good and it seems to work as expected. I found one issue, but I'm not sure it's related to this PR.

The "at a glance" widget can be resized to size 1.
Screenshot_1561714476

@malinajirka malinajirka merged commit f531996 into feature/stats_widgets_readonly Jun 28, 2019

4 checks passed

Peril All green. Yay.
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: strings-check Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
@malinajirka

This comment has been minimized.

Copy link
Contributor

commented Jun 28, 2019

The "at a glance" widget can be resized to size 1.

I'm not able to reproduce it now. It was probably just an OS issue.

🚢

@malinajirka malinajirka deleted the feature/previews_and_labels_for_widgets branch Jun 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.