Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Add realtime site address validation #10255
This adds realtime validation for the site address in Login or Add Site. This is based on the iOS implementation described in wordpress-mobile/WordPress-iOS#10294 (comment).
To implement this, I moved all the site address logic to a new class,
Adding a Site
Logging in with a self-hosted site
On both scenarios, please test against the specs described above. Please also test that there are no regressions in logging in with a valid site.
Only 1 reviewer is needed but anyone can review.
We're hoping to get a review for the error message that is shown when the URL is invalid:
For the error message, I'd go with something that explains the error a bit more fully and avoids abbreviations (like e.g.). For example:
This doesn't strike me as significantly longer than the current version, but let me know if it creates a length issue.
I like how it looks, @shiki.
I'm sorry I didn't catch this when reviewing this the first time, but I just saw that the first sentence on that screen could also use a small tweak -- the your/you sounds redundant (and it's strongly assumed that you'd only ever connect your own site). I'd go with this instead: