Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display author on post list items #10276

Merged
merged 9 commits into from Aug 13, 2019

Conversation

@malinajirka
Copy link
Contributor

commented Jul 24, 2019

Fixes #9576

Notes:

  • We need to update FluxC's hash as soon as FluxC's PR is merged.
  • #10273 needs to be reviewed and merged first

Show author name on post list items.

To test:
Note: The author label will be shown only on posts which were fetched after the update.

  1. My Site -> Blog posts
  2. Select EVERYONE in the author filter
  3. Notice the post list items contain author
  4. Switch to list mode
  5. Notice the post list items contain author
  6. Select ME in the author filter and notice the author name is not shown

Update release notes:

  • [ x ] If there are user facing changes, I have added an item to RELEASE-NOTES.txt.
Screenshot 2019-07-24 at 11 57 14 Screenshot 2019-07-24 at 11 55 15

@malinajirka malinajirka added this to the 13.0 milestone Jul 24, 2019

@malinajirka malinajirka added this to In progress in Android Post List Improvements via automation Jul 24, 2019

@jkmassel

This comment has been minimized.

Copy link
Contributor

commented Jul 30, 2019

I'm bumping this to 13.1 as part of the 13.0 code freeze.

If you'd like it to be released as part of 13.0, please merge it against release/13.0 then DM me, and I'll be happy to issue a new beta release! :)

@jkmassel jkmassel modified the milestones: 13.0, 13.1 Jul 30, 2019

Merge branch 'develop' into issue/9576-author-label-post-list
# Conflicts:
#	WordPress/src/main/res/layout/post_list_item_compact.xml
#	WordPress/src/test/java/org/wordpress/android/viewmodel/posts/PostListItemUiStateHelperTest.kt
#	build.gradle

@malinajirka malinajirka requested a review from shiki Aug 9, 2019

@malinajirka malinajirka marked this pull request as ready for review Aug 9, 2019

@loremattei loremattei modified the milestones: 13.1 ❄️, 13.2 Aug 12, 2019

@loremattei

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2019

I'm moving this to 13.2 since 13.1 has been cut. As usual, if you want this to make it to 13.1, feel free to move it back, target the release branch and ping me to build a new beta.

@shiki
shiki approved these changes Aug 12, 2019
Copy link
Member

left a comment

LGTM! Thank you. 🚢

@shiki

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

@malinajirka I didn't merge this because of the timing. I think we need to update the RELEASE-NOTES.txt? Feel free to make any changes and merge.

@malinajirka malinajirka merged commit 08b98d6 into develop Aug 13, 2019

4 checks passed

Peril All green. Congrats.
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: strings-check Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details

Android Post List Improvements automation moved this from In progress to Done Aug 13, 2019

@malinajirka malinajirka deleted the issue/9576-author-label-post-list branch Aug 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.