Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Stats accessibility improvements 2 #10277
This PR looks rather big but it needed to be this way because I had to add the content description to all the
This covers all the list items in the Stats. For example the following screenshot:
would now have the header (
There was quite a few of these list items in the Stats but all the changes should be almost the same~
Update release notes:
khaykov left a comment
I haven't noticed anything alarming in the code, but there is a lot of it, and it all looks really similar, so I hope I haven't missed anything :)
Everything works awesome! I have two comments:
A lot of non-clickable list items (Authors, Countries, Month, etc) are announced as clickable with “double-tap to activate”.
When you expand a list item, it's description says "something something, Expand" instead of "Collapse".
thanks for the review @khaykov!
It took me some time to figure this one out so I have to share why it's happening. There is this code in the
Now, as you see, it's valid to pass in
This should be fixed now.