Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/update color scheme #10283

Merged
merged 253 commits into from Jul 28, 2019

Conversation

@theck13
Copy link
Contributor

commented Jul 25, 2019

Fix

Update the color scheme to Color Studio v2.0.0 to close #10165. These changes include updating color values, refactoring color names, renaming file names based on the new color values/names, and removing unused colors. There are no functional changes.

Test

An alpha build can be downloaded from here. It will be installed alongside the production build (i.e. two WordPress apps will be on the device; one production and one debug) so changes can be compared on the same device.

Review

Only one developer is required to review these changes, but anyone can perform the review. The code review should not worry about the color names or specific changes to the color of the interface, but it should check that there are no breaking changes. The design and interface will be reviewed by @mattmiklic.

theck13 added some commits Jul 23, 2019

@mattmiklic

This comment has been minimized.

Copy link
Member

commented Jul 26, 2019

This is looking good to me; I did a side-by-side comparison of screens in this alpha build with the same screens on iOS. The only thing I noticed was the use of WordPress blue instead of the regular blue for some links and icons, which we've already talked about and we'll address later. 👍

@mattmiklic mattmiklic removed their request for review Jul 26, 2019

@khaykov khaykov self-assigned this Jul 26, 2019

@khaykov
Copy link
Member

left a comment

Looks good 👍

@khaykov khaykov merged commit 2f028c0 into develop Jul 28, 2019

4 checks passed

Peril Found some issues. Don't worry, everything is fixable.
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: strings-check Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details

@khaykov khaykov deleted the issue/update-color-scheme branch Jul 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.