Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPE on login screen when tapping Help icon #10302

Merged
merged 1 commit into from Jul 30, 2019

Conversation

@daniloercoli
Copy link
Contributor

commented Jul 30, 2019

Fix a crash on the help screen (issue reported at login screen) where we were accessing the selected site, but there isn't any site in the app yet.

To test:

  • Start a clean app
  • Tap on Login
  • Tap on the help icon (top right of the screen)

cc @jtreanor

Update release notes:

  • [ x ] If there are user facing changes, I have added an item to RELEASE-NOTES.txt.
Fix a crash on the help screen (issue reported at login phase) where …
…we were accessing the selected site, but there isn't any site in the app yet.

@daniloercoli daniloercoli added this to the 13.0 milestone Jul 30, 2019

@daniloercoli daniloercoli requested review from jtreanor and malinajirka Jul 30, 2019

@malinajirka
Copy link
Contributor

left a comment

LGTM thanks!

@malinajirka malinajirka merged commit b1af64d into develop Jul 30, 2019

4 of 5 checks passed

ci/circleci: connected-tests Your tests failed on CircleCI
Details
Peril All green. Yay.
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: strings-check Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details

@malinajirka malinajirka deleted the fix/NPE-tapping-help-on-login-screen branch Jul 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.