Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/desktop preview #10326

Merged
merged 50 commits into from Aug 5, 2019

Conversation

@khaykov
Copy link
Member

commented Aug 2, 2019

This PR adds a visual overhaul of the Web Preview screen and adds a switch between desktop and mobile version when previewing Site or Posts.

This is a feature branch, so all the code in it was already reviewed.

You don't need to test it, but if you feel like you can check usages of WPWebViewActivity, eg. Site, Post/Page Preview, Theme Preview, etc.

Image from Gyazo

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.
khaykov added 30 commits Jul 10, 2019
Merge branch 'feature/desktop-preview' of github.com:wordpress-mobile…
…/WordPress-Android into feature/toggle-between-preview-modes
Moved share and external browser functionality into toolbar.
Setting subtitle, and styling "UP" button.
khaykov and others added 9 commits Jul 29, 2019
Merge branch 'feature/desktop-preview' of github.com:wordpress-mobile…
…/WordPress-Android into feature/back-forward-navigation

# Conflicts:
#	WordPress/src/main/res/drawable/web_preview_navbar_selector.xml
Merge pull request #10226 from wordpress-mobile/feature/back-forward-…
…navigation

Feature/back forward navigation
Merge pull request #10318 from wordpress-mobile/feature/white-status-…
…bar-in-web-preview

Setting light toolbar for Web Preview
Merge branch 'develop' of github.com:wordpress-mobile/WordPress-Andro…
…id into feature/desktop-preview

# Conflicts:
#	WordPress/src/main/res/values/strings.xml
Merge branch 'feature/desktop-preview' of github.com:wordpress-mobile…
…/WordPress-Android into feature/desktop-preview

@khaykov khaykov added the Previews label Aug 2, 2019

@khaykov khaykov added this to the 13.1 milestone Aug 2, 2019

@khaykov khaykov requested review from theck13, malinajirka, 0nko and maxme and removed request for theck13 Aug 2, 2019

@theck13 theck13 self-assigned this Aug 5, 2019

@peril-wordpress-mobile

This comment has been minimized.

Copy link

commented Aug 5, 2019

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

RELEASE-NOTES.txt Outdated Show resolved Hide resolved
@theck13
theck13 approved these changes Aug 5, 2019

@theck13 theck13 merged commit d97c328 into develop Aug 5, 2019

4 checks passed

Peril Found some issues. Don't worry, everything is fixable.
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: strings-check Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details

@theck13 theck13 deleted the feature/desktop-preview branch Aug 5, 2019

@designsimply

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

eg. Site, Post/Page Preview, Theme Preview, etc.

I tried checking theme preview by going to Themes > More (three dots) > View but I don't see the desktop view switcher or any of the footer options shown in your screenshot. Is there another way to get to theme previews that I am not thinking of?

@khaykov

This comment has been minimized.

Copy link
Member Author

commented Aug 14, 2019

@designsimply For now, we are rolling our desktop/mobile preview for site and post preview only. Theme Preview is using the same code, and should not have the preview switch (that's why I mentioned it in the PR). Sorry for the confusion!

@designsimply

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

Gotcha. Thanks for the explanation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.