Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fb publicize #10376

Merged
merged 2 commits into from Aug 12, 2019

Conversation

@malinajirka
Copy link
Contributor

commented Aug 12, 2019

Hopefully fixes #9924

Fixes bug which prevented some users from establishing connection with their social media services.

To test:

  • Set "don't keep activities in the System developer settings"
  1. My Site
  2. Sharing
  3. Facebook
  4. Connect
  5. Enter your Facebook credentials
  6. The Webview asks you to provide 2-fa code
  7. Switch to the Facebook app and get the code (this is the place where we lose mServiceId)[in case your account isn't 2-fa protected, just move another app into foreground and then bring the WordPress app back]
  8. Finish the FB login and give the app access to at least one published fb page
  9. A connection to your FB page should be successfully established

Update release notes:

  • [ x ] If there are user facing changes, I have added an item to RELEASE-NOTES.txt.
@mkevins
Copy link
Contributor

left a comment

Nice and simple fix to save the serviceId outside the fragment lifecycle. Nice work @malinajirka !

@@ -86,6 +86,7 @@ public void onSaveInstanceState(Bundle outState) {
super.onSaveInstanceState(outState);
outState.putSerializable(WordPress.SITE, mSite);
outState.putInt(PublicizeConstants.ARG_CONNECTION_ID, mConnectionId);
outState.putString(PublicizeConstants.ARG_SERVICE_ID, mServiceId);

This comment has been minimized.

Copy link
@mkevins

mkevins Aug 12, 2019

Contributor

Good catch 👍

@malinajirka malinajirka merged commit 4227bcc into develop Aug 12, 2019

4 checks passed

Peril All green. Jolly good show.
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: strings-check Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details

@malinajirka malinajirka deleted the issue/9924-fix-facebook-publicize branch Aug 12, 2019

@mkevins mkevins referenced this pull request Aug 13, 2019
3 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.