Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fixes Publicize connection flow #10378
This line of code was introduce in #8115. The server responds with Http Error code 400 when we pass
Perform the same steps for Tumblr and Twitter.
Update release notes:
mkevins left a comment •
Do we have any insight about whether this will change in the future:
I am wondering if it makes sense (in a separate PR) to modify the end-point to follow the robustness principle. I was looking around here but I didn't spend a lot of time digging, and I'm not certain that's the right place. Anyway, it's outside the scope of this PR, but I wanted to comment for posterity in case a future change brings up a similar issue.
Thank you for the review! ;)
Tbh I'm a fan of the fail fast principle. Perhaps this is a case where it's on the edge, but I kind of like that the API fails right away and tells you what is wrong. Imagine you would be sending
Aug 13, 2019
I'm also a fan of fail-fast, and you bring up a good point. I suppose in a case like this, these principles are somewhat at odds with one another, and my feeling is more-or-less to be guided by the relative stability of the (external) APIs in question. Robustness may be a maintenance win, whereas fail-fast enforces more strictly defined interfaces, often with more predictable behavior.
In this particular case, we "fail fast", but we have all the information we need at that moment to not fail. I suppose ultimately, it may be a question of where such heuristics belong. I don't have a strong opinion, but definitely think there may be value in considering whether it could make sense for that logic to exist server-side (probably informed by how often these external APIs change).