Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Jetpack performance settings #10468
This PR adds Jetpack performance settings based on the desings. There is now a
On the main screen you see now
The easiest way to test this is comparing the options in Calypso with the same site to the options in the WPAndroid app. It happens that the Jetpack refuses to set the settings but it happens on both platforms.
To test - with a Jetpack site with a free plan:
To test - with a Jetpack site with a premium plan:
To test - with a Jetpack site with a business plan:
To test - with a WPCom site with a business plan:
Update release notes:
khaykov left a comment
Thanks for the PR, @planarvoid !
It mostly works as expected, but I have couple of comments:
I see an option for "Add-free video hosting" on Personal plan, where it only starts from Premium.
Behavior of the "global" Site Accelerator switch is not consistent with Calypso - over there it stays enabled if at least one child option is selected, on Android it gets disabled unless both options are selected.
I know you followed a design, but the behavior of More button is a bit weird - sometimes there is nothing extra inside it, it just repeats options from previous screen. Wonder, maybe we should hide it where there is nothing extra to show?
Missing release notes :D
Thanks for the review, @khaykov !
I've fixed this. I thought that there are only three plans (free, premium and business) and I've checked that it's removed on the free plan. Now I'm hiding it for all the plans except premium and business.
I'm checking Calypso and it doesn't make sense to me. We're setting Jetpack modules for a non-Jetpack site. Anyway, I'll do the same thing within the app.
Good catch, I've fixed that.
It is weird, you're right. I'm now hiding the "More" menu when the "Improved search" is not showing (because it's the only extra item in the preferences.